Prac mode rework #43

Kyli3Boi · 2021-05-25T07:45:20Z

No description provided.

Initial work: 1. Allows recreating savelocs Working: on stage maps, have not worked with linear maps TODO: There is a bug when recreating saveloc after you have cleared savelocs which i have not figured out as yet

This reverts commit 4801b94.

1. Fix times issues when using pause/spectate. 2. Remove some code (commented out for now) and use easier method to do this (thanks Just-Sad for pointing this out)

1. Fix bug where creating saveloc in prac returns wrong srcp time (commands.sp) 2. move float to better location (misc.sp) 3. Rework this a little for better operation as well as fix bug where no wrcp time in stage 1 after restarting map whilst you were in prac (surfzones.sp)

Just move this to here so srcptimer doesnt start if timer disabled

1. Fix issue where you couldnt start timer if restarting bonus whilst in prac

1. Add missing time to saveloc recreation 2. Fix buffersize issue for saveloc recreation 3. Add restrictions to saveloc recreation (no longer can you use command with invalid number of inputs)

1. Fix unix times in !loclist 2. Change !loclist (remove player name and add time) 3. TODO add speed into !loclist (this is very tricky, especially when it comes to players using different measures of speed, xy/xyz/z)

1. Fix issue where timer could not start after tele to stage then create saveloc then tele to saveloc then sm_rs and try start time 2. Fix issue where "StageNotRecorded" would be displayed after doing above on stage 2

1. Added print to console to display when you created saveloc 2. Change save loc recreation to less precise values which saves space and should always allow it to be inserted via chat 3. Add missing variable to recreatePlayerCheckpoint 4. Remove duplicate variable in recreatePlayerCheckpoint 5. Rename translations

Still to be tested with players but seems to work fine with bots. 1. Allow saveloc to be created from spectate. 2. Stop stage time print to chat happening in bonus when going into end zone (surfzones.sp) 3. Rename translation

1. Force GetcurrentRunTime here to fix the bug with creating a saveloc right infront of CP (showing time as 0)

addons/sourcemod/scripting/surftimer/commands.sp

addons/sourcemod/scripting/surftimer/convars.sp

addons/sourcemod/scripting/SurfTimer.sp

addons/sourcemod/scripting/surftimer/sql.sp

qawery-just-sad

LGTM

Kyli3Boi added 24 commits April 28, 2021 16:45

Latest Prac Work

d8f2b0a

Move this

51912f7

Fix naming

ceee779

Fix time issue and cleanup

57e4d02

SaveLoc Recreation!

3824e7b

Initial work: 1. Allows recreating savelocs Working: on stage maps, have not worked with linear maps TODO: There is a bug when recreating saveloc after you have cleared savelocs which i have not figured out as yet

Fix Wrcp bug when switching from spectate

4801b94

Revert "Fix Wrcp bug when switching from spectate"

f95d684

This reverts commit 4801b94.

Update

70a7222

1. Fix times issues when using pause/spectate. 2. Remove some code (commented out for now) and use easier method to do this (thanks Just-Sad for pointing this out)

Fix bugs

c10e2ea

Stop making/go to saveloc whilst spectating

9426667

Fix bug, showing another player name in !savelocs

2de9f0d

Add options for allowing checkpoint (saveloc) recreation

11c8fc9

Fix

4cb3096

1. Fix bug where creating saveloc in prac returns wrong srcp time (commands.sp) 2. move float to better location (misc.sp) 3. Rework this a little for better operation as well as fix bug where no wrcp time in stage 1 after restarting map whilst you were in prac (surfzones.sp)

Update surfzones.sp

6bc59c8

Just move this to here so srcptimer doesnt start if timer disabled

Fix

29ce31c

1. Fix issue where you couldnt start timer if restarting bonus whilst in prac

Fix

167379f

1. Add missing time to saveloc recreation 2. Fix buffersize issue for saveloc recreation 3. Add restrictions to saveloc recreation (no longer can you use command with invalid number of inputs)

Fix and Change

c11b04e

1. Fix unix times in !loclist 2. Change !loclist (remove player name and add time) 3. TODO add speed into !loclist (this is very tricky, especially when it comes to players using different measures of speed, xy/xyz/z)

Fix

0660a36

1. Fix issue where timer could not start after tele to stage then create saveloc then tele to saveloc then sm_rs and try start time 2. Fix issue where "StageNotRecorded" would be displayed after doing above on stage 2

Creating savelocs from spectate

dd599bc

Still to be tested with players but seems to work fine with bots. 1. Allow saveloc to be created from spectate. 2. Stop stage time print to chat happening in bonus when going into end zone (surfzones.sp) 3. Rename translation

Merge branch 'alternate-universe' into Prac-Mode-Rework

e5dcdbb

Fix

237f1c9

1. Force GetcurrentRunTime here to fix the bug with creating a saveloc right infront of CP (showing time as 0)

Small tidy up

7789d26

Update Version

0c74be4

Kyli3Boi requested a review from qawery-just-sad May 25, 2021 07:45

qawery-just-sad requested changes May 26, 2021

View reviewed changes

Kyli3Boi added 2 commits May 26, 2021 13:25

Complete requested changes

96b958f

Fix naming

ec4a782

Kyli3Boi requested a review from qawery-just-sad May 26, 2021 11:36

Oops forgot this one xD

924b9ed

another oops...

91fe80d

qawery-just-sad approved these changes May 26, 2021

View reviewed changes

Update CHANGELOG.md

bbd2c93

qawery-just-sad merged commit 6948a5d into qawery-just-sad:alternate-universe May 26, 2021

Kyli3Boi deleted the Prac-Mode-Rework branch September 28, 2021 20:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prac mode rework #43

Prac mode rework #43

Kyli3Boi commented May 25, 2021

qawery-just-sad left a comment

Prac mode rework #43

Prac mode rework #43

Conversation

Kyli3Boi commented May 25, 2021

qawery-just-sad left a comment

Choose a reason for hiding this comment