Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded call to private scipy function in SAR reader #2968

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Nov 5, 2024

This PR removes an unneeded call (!) from a private (!) scipy function in the SAR reader. Said function has moreover been removed from newer scipy, making the experimental ci jobs crash.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.10%. Comparing base (28a793c) to head (a0a7f53).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2968      +/-   ##
==========================================
+ Coverage   96.08%   96.10%   +0.01%     
==========================================
  Files         377      377              
  Lines       55134    55134              
==========================================
+ Hits        52976    52984       +8     
+ Misses       2158     2150       -8     
Flag Coverage Δ
behaviourtests 3.94% <0.00%> (ø)
unittests 96.19% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11680219286

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 96.206%

Totals Coverage Status
Change from base Build 11678446960: 0.01%
Covered Lines: 53228
Relevant Lines: 55327

💛 - Coveralls

@mraspaud mraspaud merged commit afb1cc5 into pytroll:main Nov 5, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants