Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build not working with Python 3.13.0b1 #104

Closed
Dunedan opened this issue Jun 5, 2024 · 7 comments · Fixed by #105
Closed

Build not working with Python 3.13.0b1 #104

Dunedan opened this issue Jun 5, 2024 · 7 comments · Fixed by #105

Comments

@Dunedan
Copy link

Dunedan commented Jun 5, 2024

Building a wheel for marisa-trie with Python 3.13.0b1 doesn't work, because there are no _PyLong_AsByteArray() and _PyLong_FromByteArray() functions anymore.

The is a CPython issue on this topic (python/cpython#111140), which resulted in alternative public functions being available, so I guess supporting Python 3.13 with marisa-trie should be pretty straight-forward.

Here is a log of a failed build with Python 3.13.0b1: build-log-marisa-trie-python-3.13.txt

@BoboTiG
Copy link
Contributor

BoboTiG commented Jun 5, 2024

Hello @Dunedan!

Thanks for the report, I'll see to add Python 3.13 support 👍🏻

@BoboTiG
Copy link
Contributor

BoboTiG commented Jun 5, 2024

With v1.2.0 you can now build marisa-trie on Python 3.13 beta 1!

But Python 3.13 wheels won't be published as of now since it is not recommanded by cibuildwheel:

This option is provided for testing purposes only. It is not recommended to distribute wheels built when CIBW_PRERELEASE_PYTHONS is set, such as uploading to PyPI. Please do not upload these wheels to PyPI, as they are not guaranteed to work with the final Python release. Once Python is ABI stable and enters the release candidate phase, that version of Python will become available without this flag.

I am now following Cython releases to keep up-to-date C code here, and improve Python 3.13 (and newer versions) support.

@iherasymenko
Copy link

@BoboTiG could you please cut a release? Looks like the 3.13 ABI is now stable.

@BoboTiG
Copy link
Contributor

BoboTiG commented Sep 16, 2024

@iherasymenko I'm on it!

@BoboTiG
Copy link
Contributor

BoboTiG commented Sep 16, 2024

Arf, Python 3.13 wheels worked but not PyPy 3.8, see https://github.com/pytries/marisa-trie/actions/runs/10892762632/job/30226353003

The issue is already tracked upstream: pypa/distutils#283

@Dunedan
Copy link
Author

Dunedan commented Sep 17, 2024

@BoboTiG could you please cut a release? Looks like the 3.13 ABI is now stable.

Didn't 1.2.0 get already released for Python 3.13 support?

@BoboTiG
Copy link
Contributor

BoboTiG commented Sep 17, 2024

@BoboTiG could you please cut a release? Looks like the 3.13 ABI is now stable.

Didn't 1.2.0 get already released for Python 3.13 support?

Yes, but Python 3.13 wheels were not made available at the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants