-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lowered hardswish #3492
Comments
Thanks for reporting, I will add this to our op lowering queue. |
Would it be simple enough to replicate this PR, but with the function calculation changed? I have minimal experience with under the hood of this codebase, but I'm happy to give it a shot. |
it would be pretty similar to that I think. Some of the things in that pr is out of date (like we no longer has Please refer to https://github.com/pytorch/xla/blob/master/CONTRIBUTING.md for building pt/xla and https://github.com/pytorch/xla/blob/master/OP_LOWERING_GUIDE.md for how to lower an op. Happy to help if you run into issues. |
Thanks for the pointers. I've got a branch ready to push, but I can't access the repo. I'm not sure whether the problem is on my side or not, so naive question: should I have push/write access to the repo by default? |
Ah, so since you do not have Before you opening a pull requiest, also make sure to run the formater and build is passing. You can refer to https://github.com/pytorch/xla/blob/master/CONTRIBUTING.md#before-submiting-a-pull-request |
I get the error:
"No more forks can be created. View existing forks."
Perhaps I can just use an existing fork?
|
Seems like you already fork a pytorch/xla in https://github.com/lucasc896/xla |
Closing as #3496 is merged. Thanks! |
🚀 Feature
A lowered version of hardswish to enable performant use of
torchvision.models.mobilenet_v3_small
and other models on TPUThe text was updated successfully, but these errors were encountered: