Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend TorchVision smoke tests to MPS #7365

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Extend TorchVision smoke tests to MPS #7365

merged 1 commit into from
Mar 1, 2023

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Mar 1, 2023 •
edited
Loading

Verification for pytorch/pytorch#86954

Validated locally by running:

$ pip install torch torchvision --pre --extra-index-url https://download.pytorch.org/whl/nightly/cpu
$ python -c "from smoke_test import smoke_test_torchvision_resnet50_classify as classify;classify('mps')" 
German shepherd (mps): 34.1%

@malfet malfet requested a review from atalman March 1, 2023 00:47
@NicolasHug NicolasHug merged commit feda8b7 into main Mar 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Hey @NicolasHug!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

NicolasHug pushed a commit to NicolasHug/vision that referenced this pull request Mar 1, 2023
@malfet @NicolasHug
Extend TorchVision smoke tests to MPS (pytorch#7365)
e81d332
This was referenced Mar 1, 2023
Merged
Closed
NicolasHug added a commit that referenced this pull request Mar 1, 2023
@NicolasHug @pmeier
[Cherry-pick for 0.15] Revert CP of " Extend TorchVision smoke tests …
7bd9632 
…to MPS (#7365) " (#7368)

Co-authored-by: Philip Meier <[email protected]>
@NicolasHug
Copy link
Member

Just FYI @malfet this PR is still merged on main, but I had to revert it from the release branch because it was failing there #7368

@malfet malfet deleted the malfet-patch-1 branch March 1, 2023 14:32
@malfet
Copy link
Contributor Author

malfet commented Mar 1, 2023

@NicolasHug thank you for the approval, cherry-pick and revert. This is expected to work in PyTorch-2.0 branch, but only after RC2 build (that includes cherry-pick for kulinseth/pytorch@4886ab1 ) becomes available

facebook-github-bot pushed a commit that referenced this pull request Mar 30, 2023
@NicolasHug @facebook-github-bot
[fbsync] Extend TorchVision smoke tests to MPS (#7365)
0ff64a8 
Reviewed By: vmoens

Differential Revision: D44416562

fbshipit-source-id: dcb12c77a56d8a257e6c49416be67f89d6dca9ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

@atalman atalman Awaiting requested review from atalman

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@malfet @NicolasHug @facebook-github-bot