Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up improvements to RAFT training reference #5056

Closed
3 of 7 tasks
NicolasHug opened this issue Dec 8, 2021 · 1 comment
Closed
3 of 7 tasks

Follow-up improvements to RAFT training reference #5056

NicolasHug opened this issue Dec 8, 2021 · 1 comment

Comments

@NicolasHug
Copy link
Member

NicolasHug commented Dec 8, 2021

This issue is to keep track of the progress on some minor improvements related to the RAFT training reference, as a follow up to #4644

  • support --weights param to support the prototype API, once pre-trained weights are available
  • support --model instead of the --small flag
  • support --epochs param instead of --num-steps, for consistency with the rest of the training references.
  • save the scheduler and the optimizer, not just the model.
  • try to keep function names as close as possible to existing references. For example validate() -> evaluate()
  • Support --device (?? - not sure how useful it would be)
  • Better support of weight serialization (move on CPU, avoid having the DDP model weights etc)

cc @datumbox

@NicolasHug
Copy link
Member Author

I beleieve all the remaining points have been addressed by @YosuaMichael in #5590. Thanks Yosua!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants