Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README out of date re: torch compatibility #1762

Closed
dataframing opened this issue Jan 16, 2020 · 3 comments
Closed

README out of date re: torch compatibility #1762

dataframing opened this issue Jan 16, 2020 · 3 comments

Comments

@dataframing
Copy link
Contributor

dataframing commented Jan 16, 2020

Under the README's Installation section it states:

TorchVision requires PyTorch 1.2 or newer.

This doesn't seem to be true as of 0.5.0. In a clean environment:

$ pipenv --python 3.7
$ pipenv install torchvision
$ pipenv graph
torchvision==0.5.0
  - numpy [required: Any, installed: 1.18.1]
  - pillow [required: >=4.1.1, installed: 7.0.0]
  - six [required: Any, installed: 1.14.0]
  - torch [required: ==1.4.0, installed: 1.4.0]  <<< Strict requirement: torch==1.4.0

This seems related to #1257. Is this intended? Thanks.

Update: it seems like this is intended as per #1717. Maybe that PR should also update the README?

@fmassa
Copy link
Member

fmassa commented Jan 17, 2020

Yes, the README is outdated, it now requires PyTorch 1.4 or newer. Can you send a PR improving the README?

@dataframing
Copy link
Contributor Author

@fmassa Sure thing! I've opened #1767. Thanks 👍

@fmassa
Copy link
Member

fmassa commented Jan 22, 2020

Fixed via #1767 , thanks @dataframing for the fix!

@fmassa fmassa closed this as completed Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants