Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix wheels and nightly #417

Merged
merged 3 commits into from
Jun 14, 2023
Merged

[BugFix] Fix wheels and nightly #417

merged 3 commits into from
Jun 14, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jun 14, 2023

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 14, 2023
@github-actions
Copy link

github-actions bot commented Jun 14, 2023

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 47. Improved: $\large\color{#35bf28}2$. Worsened: $\large\color{#d91a1a}3$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_common_ops 1.1006ms 1.0422ms 959.5374 Ops/s 971.9139 Ops/s $\color{#d91a1a}-1.27\%$
test_creation 4.7050μs 4.3962μs 227.4692 KOps/s 224.8979 KOps/s $\color{#35bf28}+1.14\%$
test_creation_empty 12.0489μs 11.6145μs 86.0991 KOps/s 86.6199 KOps/s $\color{#d91a1a}-0.60\%$
test_creation_nested_1 21.8859μs 20.9169μs 47.8081 KOps/s 48.0940 KOps/s $\color{#d91a1a}-0.59\%$
test_creation_nested_2 22.4478μs 21.7610μs 45.9539 KOps/s 45.8055 KOps/s $\color{#35bf28}+0.32\%$
test_clone 28.9318μs 28.0150μs 35.6952 KOps/s 36.7856 KOps/s $\color{#d91a1a}-2.96\%$
test_getitem[int] 33.3813μs 32.8936μs 30.4010 KOps/s 30.1764 KOps/s $\color{#35bf28}+0.74\%$
test_getitem[slice_int] 69.5334μs 68.8901μs 14.5159 KOps/s 14.3874 KOps/s $\color{#35bf28}+0.89\%$
test_getitem[range] 68.3231μs 67.7330μs 14.7639 KOps/s 14.6930 KOps/s $\color{#35bf28}+0.48\%$
test_getitem[tuple] 64.4379μs 63.8618μs 15.6588 KOps/s 15.1613 KOps/s $\color{#35bf28}+3.28\%$
test_getitem[list] 67.1831μs 58.4466μs 17.1096 KOps/s 17.1215 KOps/s $\color{#d91a1a}-0.07\%$
test_setitem_dim[int] 79.3990μs 48.0078μs 20.8299 KOps/s 21.0998 KOps/s $\color{#d91a1a}-1.28\%$
test_setitem_dim[slice_int] 0.1315ms 86.9329μs 11.5031 KOps/s 11.5559 KOps/s $\color{#d91a1a}-0.46\%$
test_setitem_dim[range] 0.1337ms 79.8956μs 12.5163 KOps/s 12.6913 KOps/s $\color{#d91a1a}-1.38\%$
test_setitem_dim[tuple] 0.1230ms 80.7735μs 12.3803 KOps/s 12.5885 KOps/s $\color{#d91a1a}-1.65\%$
test_setitem 44.0116μs 38.0145μs 26.3058 KOps/s 30.9089 KOps/s $\textbf{\color{#d91a1a}-14.89\%}$
test_set 33.7997μs 32.7439μs 30.5401 KOps/s 31.5319 KOps/s $\color{#d91a1a}-3.15\%$
test_set_shared 0.1468ms 0.1446ms 6.9163 KOps/s 6.9919 KOps/s $\color{#d91a1a}-1.08\%$
test_update 38.5896μs 36.5291μs 27.3754 KOps/s 28.4678 KOps/s $\color{#d91a1a}-3.84\%$
test_update_nested 56.4434μs 55.7665μs 17.9319 KOps/s 18.3225 KOps/s $\color{#d91a1a}-2.13\%$
test_set_nested 44.1516μs 43.0392μs 23.2346 KOps/s 23.7076 KOps/s $\color{#d91a1a}-2.00\%$
test_set_nested_new 66.5613μs 60.9072μs 16.4184 KOps/s 16.6288 KOps/s $\color{#d91a1a}-1.27\%$
test_select 0.1035ms 0.1007ms 9.9298 KOps/s 9.9902 KOps/s $\color{#d91a1a}-0.60\%$
test_creation[device0] 1.0854ms 0.4210ms 2.3754 KOps/s 2.0844 KOps/s $\textbf{\color{#35bf28}+13.97\%}$
test_creation_from_tensor 0.5355ms 0.3944ms 2.5353 KOps/s 2.5060 KOps/s $\color{#35bf28}+1.17\%$
test_add_one[memmap_tensor0] 45.2145μs 30.3809μs 32.9155 KOps/s 33.2176 KOps/s $\color{#d91a1a}-0.91\%$
test_contiguous[memmap_tensor0] 9.0379μs 8.1957μs 122.0150 KOps/s 122.1975 KOps/s $\color{#d91a1a}-0.15\%$
test_stack[memmap_tensor0] 0.1460ms 38.4897μs 25.9810 KOps/s 25.8735 KOps/s $\color{#35bf28}+0.42\%$
test_reshape_pytree 38.3176μs 35.8254μs 27.9132 KOps/s 28.0893 KOps/s $\color{#d91a1a}-0.63\%$
test_reshape_td 52.5995μs 50.2152μs 19.9143 KOps/s 20.1785 KOps/s $\color{#d91a1a}-1.31\%$
test_view_pytree 33.8297μs 33.0747μs 30.2346 KOps/s 30.2845 KOps/s $\color{#d91a1a}-0.17\%$
test_view_td 9.9319μs 9.2232μs 108.4217 KOps/s 108.3199 KOps/s $\color{#35bf28}+0.09\%$
test_unbind_pytree 39.1776μs 37.8650μs 26.4096 KOps/s 26.4683 KOps/s $\color{#d91a1a}-0.22\%$
test_unbind_td 0.1548ms 0.1517ms 6.5938 KOps/s 6.6076 KOps/s $\color{#d91a1a}-0.21\%$
test_split_pytree 44.0756μs 42.1673μs 23.7150 KOps/s 23.8842 KOps/s $\color{#d91a1a}-0.71\%$
test_split_td 0.1208ms 0.1190ms 8.4036 KOps/s 8.5111 KOps/s $\color{#d91a1a}-1.26\%$
test_add_pytree 46.9255μs 45.1031μs 22.1714 KOps/s 22.2400 KOps/s $\color{#d91a1a}-0.31\%$
test_add_td 64.6834μs 62.9328μs 15.8900 KOps/s 16.1521 KOps/s $\color{#d91a1a}-1.62\%$
test_distributed 62.5000μs 62.5000μs 16.0000 KOps/s 13.2275 KOps/s $\textbf{\color{#35bf28}+20.96\%}$
test_tdmodule 53.0000μs 24.8249μs 40.2821 KOps/s 40.5297 KOps/s $\color{#d91a1a}-0.61\%$
test_tdmodule_dispatch 40.3461ms 56.0045μs 17.8557 KOps/s 19.2983 KOps/s $\textbf{\color{#d91a1a}-7.48\%}$
test_tdseq 0.1776ms 30.9624μs 32.2973 KOps/s 32.0573 KOps/s $\color{#35bf28}+0.75\%$
test_tdseq_dispatch 0.1350ms 54.3816μs 18.3886 KOps/s 18.3795 KOps/s $\color{#35bf28}+0.05\%$
test_instantiation_functorch 1.6616ms 1.5498ms 645.2248 Ops/s 656.6310 Ops/s $\color{#d91a1a}-1.74\%$
test_instantiation_td 6.4080ms 1.2275ms 814.6527 Ops/s 864.0172 Ops/s $\textbf{\color{#d91a1a}-5.71\%}$
test_exec_functorch 0.1838ms 0.1783ms 5.6090 KOps/s 5.6159 KOps/s $\color{#d91a1a}-0.12\%$
test_exec_td 0.3071ms 0.3038ms 3.2912 KOps/s 3.2916 KOps/s $\color{#d91a1a}-0.01\%$

@github-actions
Copy link

github-actions bot commented Jun 14, 2023

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 47. Improved: $\large\color{#35bf28}2$. Worsened: $\large\color{#d91a1a}23$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_common_ops 1.6317ms 1.4989ms 667.1408 Ops/s 689.9962 Ops/s $\color{#d91a1a}-3.31\%$
test_creation 9.5460μs 4.2850μs 233.3701 KOps/s 253.7007 KOps/s $\textbf{\color{#d91a1a}-8.01\%}$
test_creation_empty 27.4621μs 12.0698μs 82.8517 KOps/s 76.4110 KOps/s $\textbf{\color{#35bf28}+8.43\%}$
test_creation_nested_1 42.9692μs 23.4593μs 42.6271 KOps/s 41.6122 KOps/s $\color{#35bf28}+2.44\%$
test_creation_nested_2 40.6252μs 24.1917μs 41.3365 KOps/s 41.5782 KOps/s $\color{#d91a1a}-0.58\%$
test_clone 52.2362μs 32.1302μs 31.1233 KOps/s 32.2741 KOps/s $\color{#d91a1a}-3.57\%$
test_getitem[int] 61.8304μs 39.2997μs 25.4455 KOps/s 25.3485 KOps/s $\color{#35bf28}+0.38\%$
test_getitem[slice_int] 0.1091ms 85.7473μs 11.6622 KOps/s 11.9790 KOps/s $\color{#d91a1a}-2.64\%$
test_getitem[range] 0.1529ms 0.1081ms 9.2478 KOps/s 9.7734 KOps/s $\textbf{\color{#d91a1a}-5.38\%}$
test_getitem[tuple] 97.4998μs 77.2036μs 12.9528 KOps/s 14.0751 KOps/s $\textbf{\color{#d91a1a}-7.97\%}$
test_getitem[list] 0.1241ms 95.7006μs 10.4493 KOps/s 11.4791 KOps/s $\textbf{\color{#d91a1a}-8.97\%}$
test_setitem_dim[int] 1.8965ms 65.2326μs 15.3298 KOps/s 16.0902 KOps/s $\color{#d91a1a}-4.73\%$
test_setitem_dim[slice_int] 9.6385ms 0.1234ms 8.1009 KOps/s 8.8228 KOps/s $\textbf{\color{#d91a1a}-8.18\%}$
test_setitem_dim[range] 3.4397ms 0.1311ms 7.6267 KOps/s 8.3903 KOps/s $\textbf{\color{#d91a1a}-9.10\%}$
test_setitem_dim[tuple] 7.6708ms 0.1050ms 9.5226 KOps/s 9.9501 KOps/s $\color{#d91a1a}-4.30\%$
test_setitem 73.2392μs 41.9898μs 23.8153 KOps/s 26.0348 KOps/s $\textbf{\color{#d91a1a}-8.53\%}$
test_set 68.3472μs 40.0043μs 24.9973 KOps/s 27.1535 KOps/s $\textbf{\color{#d91a1a}-7.94\%}$
test_set_shared 0.3347ms 0.2782ms 3.5942 KOps/s 3.4351 KOps/s $\color{#35bf28}+4.63\%$
test_update 89.5963μs 43.9588μs 22.7486 KOps/s 25.7463 KOps/s $\textbf{\color{#d91a1a}-11.64\%}$
test_update_nested 83.3782μs 61.9012μs 16.1548 KOps/s 16.2276 KOps/s $\color{#d91a1a}-0.45\%$
test_set_nested 80.0493μs 53.7415μs 18.6076 KOps/s 19.6578 KOps/s $\textbf{\color{#d91a1a}-5.34\%}$
test_set_nested_new 0.1002ms 70.3345μs 14.2178 KOps/s 14.9667 KOps/s $\textbf{\color{#d91a1a}-5.00\%}$
test_select 0.1835ms 0.1160ms 8.6235 KOps/s 8.9505 KOps/s $\color{#d91a1a}-3.65\%$
test_creation[device0] 1.4591ms 0.6224ms 1.6066 KOps/s 1.5526 KOps/s $\color{#35bf28}+3.48\%$
test_creation_from_tensor 0.8454ms 0.6266ms 1.5960 KOps/s 1.6857 KOps/s $\textbf{\color{#d91a1a}-5.32\%}$
test_add_one[memmap_tensor0] 88.6553μs 61.2212μs 16.3342 KOps/s 17.2464 KOps/s $\textbf{\color{#d91a1a}-5.29\%}$
test_contiguous[memmap_tensor0] 27.0832μs 12.3093μs 81.2397 KOps/s 82.2846 KOps/s $\color{#d91a1a}-1.27\%$
test_stack[memmap_tensor0] 0.2369ms 84.1705μs 11.8806 KOps/s 9.7761 KOps/s $\textbf{\color{#35bf28}+21.53\%}$
test_reshape_pytree 64.3355μs 37.8004μs 26.4548 KOps/s 26.7927 KOps/s $\color{#d91a1a}-1.26\%$
test_reshape_td 0.1076ms 57.9068μs 17.2691 KOps/s 17.9814 KOps/s $\color{#d91a1a}-3.96\%$
test_view_pytree 59.5004μs 33.8818μs 29.5144 KOps/s 29.6972 KOps/s $\color{#d91a1a}-0.62\%$
test_view_td 28.2732μs 8.8716μs 112.7196 KOps/s 108.5681 KOps/s $\color{#35bf28}+3.82\%$
test_unbind_pytree 58.2534μs 38.8440μs 25.7440 KOps/s 25.1366 KOps/s $\color{#35bf28}+2.42\%$
test_unbind_td 0.2871ms 0.1879ms 5.3219 KOps/s 5.3992 KOps/s $\color{#d91a1a}-1.43\%$
test_split_pytree 75.1266μs 47.3278μs 21.1292 KOps/s 22.5276 KOps/s $\textbf{\color{#d91a1a}-6.21\%}$
test_split_td 0.1933ms 0.1492ms 6.7026 KOps/s 7.2206 KOps/s $\textbf{\color{#d91a1a}-7.17\%}$
test_add_pytree 0.1298ms 61.2326μs 16.3312 KOps/s 17.3384 KOps/s $\textbf{\color{#d91a1a}-5.81\%}$
test_add_td 0.2000ms 0.1006ms 9.9406 KOps/s 10.8604 KOps/s $\textbf{\color{#d91a1a}-8.47\%}$
test_distributed 0.1022ms 0.1022ms 9.7847 KOps/s 9.8716 KOps/s $\color{#d91a1a}-0.88\%$
test_tdmodule 1.3460ms 39.2663μs 25.4671 KOps/s 29.3432 KOps/s $\textbf{\color{#d91a1a}-13.21\%}$
test_tdmodule_dispatch 3.5422ms 84.7081μs 11.8053 KOps/s 13.8020 KOps/s $\textbf{\color{#d91a1a}-14.47\%}$
test_tdseq 1.9049ms 49.8520μs 20.0594 KOps/s 22.5121 KOps/s $\textbf{\color{#d91a1a}-10.89\%}$
test_tdseq_dispatch 2.2544ms 94.0577μs 10.6318 KOps/s 11.7990 KOps/s $\textbf{\color{#d91a1a}-9.89\%}$
test_instantiation_functorch 2.2505ms 1.8365ms 544.5035 Ops/s 566.3427 Ops/s $\color{#d91a1a}-3.86\%$
test_instantiation_td 2.2254ms 1.4715ms 679.5648 Ops/s 735.0577 Ops/s $\textbf{\color{#d91a1a}-7.55\%}$
test_exec_functorch 0.3501ms 0.2662ms 3.7569 KOps/s 3.9733 KOps/s $\textbf{\color{#d91a1a}-5.45\%}$
test_exec_td 0.5202ms 0.4312ms 2.3191 KOps/s 2.3656 KOps/s $\color{#d91a1a}-1.97\%$

@vmoens vmoens added the CI label Jun 14, 2023
@vmoens vmoens merged commit 13ffa31 into main Jun 14, 2023
@vmoens vmoens deleted the fix_wheels branch June 14, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants