-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Versioning] Gymnasium 1.0 incompatibility errors #2484
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2484
Note: Links to docs will display an error until the docs builds have been completed. ❌ 13 New Failures, 5 Unrelated FailuresAs of commit a126b0c with merge base efa5745 (): NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ghstack-source-id: 8f067bf5a1c023e911e349b4a639118796aa259a Pull Request resolved: #2484
changes in the Gym API. | ||
Using gymnasium 1.0 with TorchRL would require significant modifications to your code and may result in: | ||
* Inaccurate step counting, as the auto-reset feature can cause unpredictable numbers of steps to be executed. | ||
* Potential data corruption, as the environment may require/produce garbage data during reset steps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Potential data corruption, as the environment may require/produce garbage data during reset steps. | |
* Potential data corruption, as the environment may require/produce invalid data during reset steps. |
GYMNASIUM_1_ERROR = """RuntimeError: TorchRL does not support gymnasium 1.0 or later versions due to incompatible | ||
changes in the Gym API. | ||
Using gymnasium 1.0 with TorchRL would require significant modifications to your code and may result in: | ||
* Inaccurate step counting, as the auto-reset feature can cause unpredictable numbers of steps to be executed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Inaccurate step counting, as the auto-reset feature can cause unpredictable numbers of steps to be executed. | |
* Inaccurate step counting, the number of step calls to obtain the same amount of data using the autoreset feature will depend on the done frequency of the enviornment. |
Using gymnasium 1.0 with TorchRL would require significant modifications to your code and may result in: | ||
* Inaccurate step counting, as the auto-reset feature can cause unpredictable numbers of steps to be executed. | ||
* Potential data corruption, as the environment may require/produce garbage data during reset steps. | ||
* Trajectory overlap during data collection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe explain this one too
* Inaccurate step counting, as the auto-reset feature can cause unpredictable numbers of steps to be executed. | ||
* Potential data corruption, as the environment may require/produce garbage data during reset steps. | ||
* Trajectory overlap during data collection. | ||
* Increased computational overhead, as the library would need to handle the additional complexity of auto-resets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Increased computational overhead, as the library would need to handle the additional complexity of auto-resets. | |
* Increased computational overhead, as auto-resets introduce additional computational complexity. |
ghstack-source-id: 458e9762ec95b008667cce28a23268b77e421042 Pull Request resolved: #2484
ghstack-source-id: 458e9762ec95b008667cce28a23268b77e421042 Pull Request resolved: #2484
Stack from ghstack (oldest at bottom):