Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support wrapping IsaacLab environments with GymEnv #2380

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

yu-fz
Copy link
Contributor

@yu-fz yu-fz commented Aug 8, 2024

Description

Adds a configuration parameter to GymLikeEnv to specify whether or not actions should be converted to numpy arrays before being passed to the step function of the underlying environment to retrieve the next state. Users can now pass convert_actions_to_numpy=False when wrapping environments that work with torch tensors.

Let me know if a new test is required for this.

Motivation and Context

Previously, it was assumed that the step function argument expected numpy array types on CPU, which makes torchrl incompatible with environments like IsaacLab that operate on torch tensors and on the GPU.

If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213
Closes #2369

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • [] Example (update in the folder of examples)

Checklist

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

Copy link

pytorch-bot bot commented Aug 8, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2380

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 2 Cancelled Jobs, 7 Unrelated Failures

As of commit 73596a8 with merge base 607db8b (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 8, 2024
@vmoens vmoens added bug Something isn't working enhancement New feature or request labels Aug 9, 2024
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I guess that then we should also document better how to use the new Isaac API

Ideally, I'd like not to rely on Gym for Isaac and wrap the simulator directly, but first let's focus on making it work like this!

@vmoens vmoens merged commit a6310ae into pytorch:main Aug 9, 2024
59 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Make GymLikeEnv compatible with IsaacLab Envs
3 participants