-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support wrapping IsaacLab environments with GymEnv #2380
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2380
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 2 Cancelled Jobs, 7 Unrelated FailuresAs of commit 73596a8 with merge base 607db8b (): NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I guess that then we should also document better how to use the new Isaac API
Ideally, I'd like not to rely on Gym for Isaac and wrap the simulator directly, but first let's focus on making it work like this!
Description
Adds a configuration parameter to
GymLikeEnv
to specify whether or not actions should be converted to numpy arrays before being passed to the step function of the underlying environment to retrieve the next state. Users can now passconvert_actions_to_numpy=False
when wrapping environments that work with torch tensors.Let me know if a new test is required for this.
Motivation and Context
Previously, it was assumed that the step function argument expected numpy array types on CPU, which makes torchrl incompatible with environments like IsaacLab that operate on torch tensors and on the GPU.
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213
if this solves the issue #15213Closes #2369
Types of changes
Checklist