Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix tanh normal mode #2198

Merged
merged 14 commits into from
Jun 24, 2024
Merged

[BugFix] Fix tanh normal mode #2198

merged 14 commits into from
Jun 24, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jun 3, 2024

Solves #2186, please post comments about the feature in that discussion.

Related PR: pytorch/tensordict#824

cc @matteobettini

Copy link

pytorch-bot bot commented Jun 3, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2198

Note: Links to docs will display an error until the docs builds have been completed.

❌ 10 New Failures, 3 Unrelated Failures

As of commit f1b6aad with merge base 1d729e8 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 3, 2024
@vmoens vmoens added bug Something isn't working distributions labels Jun 3, 2024
@vmoens vmoens merged commit 00b7c2e into main Jun 24, 2024
45 of 58 checks passed
@vmoens vmoens deleted the fix-mode-tanhnormal branch June 24, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. distributions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants