Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FCOS #265

Closed
jdsgomes opened this issue Jan 25, 2022 · 3 comments
Closed

Add FCOS #265

jdsgomes opened this issue Jan 25, 2022 · 3 comments

Comments

@jdsgomes
Copy link

FCOS model has been recently added to TorchVision, therefore should also be added here

pytorch/vision#4961

@NicolasHug
Copy link
Member

Thanks for the issue @jdsgomes , would you like to submit a PR?

@datumbox
Copy link
Contributor

FCOS uses the C++ ops of TorchVision like nms. I'm not sure we can add it on TorchHub without creating fallback ops in standard PyTorch.

We know that such fallback ops are likely to be slower than the C++/CUDA equivalents but because these were implemented several years ago, we don't know how much slower they will be. It might be worth benchmarking this on the future and assess if fallback ops is a viable strategy to expose our models via TorchHub. I think for now, we are probably going to close the ticket as nofix?

@jdsgomes
Copy link
Author

Thanks for raising those important points @datumbox. Closing the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants