Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise Error when HTTPReader get 503 Response #160

Closed
ejguan opened this issue Jan 5, 2022 · 4 comments
Closed

Raise Error when HTTPReader get 503 Response #160

ejguan opened this issue Jan 5, 2022 · 4 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@ejguan
Copy link
Contributor

ejguan commented Jan 5, 2022

🐛 Describe the bug

As I was testing the https://github.com/pytorch/data/blob/main/examples/text/CC100.ipynb, it would yield Error saying the object can not be decoded. I dug a little bit and found the root cause was HTTPResponse is a 503 Error.

But, I would expect the Error/Exception should be caught by HTTPReader
https://github.com/pytorch/pytorch/blob/2431218ee4ac1d2f016188c29869d817f6e3c70c/torch/utils/data/datapipes/iter/httpreader.py#L33-L38.

Not sure if this is related to streaming option. Needs to investigate.

Versions

main

Additional Context for New Contributors

See comment below

cc: @NivekT

@NivekT NivekT added the good first issue Good for newcomers label Feb 11, 2022
@NivekT
Copy link
Contributor

NivekT commented Mar 7, 2022

For new contributors who would like to work on this issue, we recommend:

  1. Reproduce the exception if possible
  2. Implement changes that catch the error in HTTPReader and handle/re-raise the error as appropriate
  3. Update the unit test for HTTPReader to ensure the new behavior works as expected

@NivekT NivekT changed the title Raise Error when HTTPReader get 503 Respnonse Raise Error when HTTPReader get 503 Response Mar 7, 2022
@diegoaichele
Copy link
Contributor

diegoaichele commented Jun 18, 2022

Can I help with this issue or is it already fixed?

cc: @NivekT

@NivekT
Copy link
Contributor

NivekT commented Jun 20, 2022

@diegoaichele This has not been fixed yet. Please go ahead. Feel free to comment here if you have questions or open a PR. Thanks!

@diegoaichele
Copy link
Contributor

@NivekT can you assign it to me?, I will do my best. (first time doing a PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants