Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InMemoryCache dp will yield from source dp once even when data is fully cached #1159

Closed
hirayaku opened this issue May 13, 2023 · 0 comments
Closed

InMemoryCache dp will yield from source dp once even when data is fully cached #1159

hirayaku opened this issue May 13, 2023 · 0 comments

Comments

@hirayaku
Copy link
Contributor

🐛 Describe the bug

The InMemoryCacheHolderIterDataPipe will try yielding from source_dp once even when the data from the source is fully cached. This can cause unexpected IO for users. Adding a condition check before enumerating source_dp should fix it.

Versions

Torch==2.0.1, TorchData==0.6.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent in_memory_cache from yielding from source_dp when it's fully cached hirayaku/data
1 participant
@hirayaku