From ee2761f5a0a997faa08613ff558794aaed3662d7 Mon Sep 17 00:00:00 2001 From: atalman Date: Fri, 10 Feb 2023 11:00:09 -0800 Subject: [PATCH 1/5] Test windows py311 --- .github/scripts/validate_binaries.sh | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/scripts/validate_binaries.sh b/.github/scripts/validate_binaries.sh index f05d9b20a..2b17ba72b 100755 --- a/.github/scripts/validate_binaries.sh +++ b/.github/scripts/validate_binaries.sh @@ -3,7 +3,7 @@ if [[ ${MATRIX_PACKAGE_TYPE} == "libtorch" ]]; then unzip libtorch.zip else #special case for Python 3.11 - if [ $MATRIX_PYTHON_VERSION == '3.11' ]; then + if [ $MATRIX_PYTHON_VERSION == '3.11' && ${TARGET_OS} != 'windows']; then export CPYTHON_VERSIONS=3.11.0 sudo yum -y install openssl-devel libssl-dev bzip2-devel libffi-devel sudo yum -y groupinstall "Development Tools" @@ -15,6 +15,12 @@ else eval ${PYTHON_PATH}/python --version eval ${PIP_INSTALLATION} eval ${PYTHON_PATH}/python ./test/smoke_test/smoke_test.py --package torchonly + #special case for Python 3.11 + elif [ $MATRIX_PYTHON_VERSION == '3.11' && ${TARGET_OS} == 'windows']; then + conda create -y -n ${ENV_NAME} python=${MATRIX_PYTHON_VERSION} + conda activate ${ENV_NAME} + eval $MATRIX_INSTALLATION + eval ${PYTHON_PATH}/python ./test/smoke_test/smoke_test.py --package torchonly else # Special case Pypi installation package, only applicable to linux nightly CUDA 11.7 builds, wheel package From cbf80ca5fdb8a2fce5552591ebe0f60dd87d04fe Mon Sep 17 00:00:00 2001 From: atalman Date: Fri, 10 Feb 2023 11:27:29 -0800 Subject: [PATCH 2/5] Nightly binaries --- .github/workflows/validate-nightly-binaries.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/validate-nightly-binaries.yml b/.github/workflows/validate-nightly-binaries.yml index c252e0433..32c6781ba 100644 --- a/.github/workflows/validate-nightly-binaries.yml +++ b/.github/workflows/validate-nightly-binaries.yml @@ -32,4 +32,3 @@ jobs: with: channel: nightly os: all - limit-win-builds: enable From 79c14b230ab9bc06a7fecb1fe0a355bb39500145 Mon Sep 17 00:00:00 2001 From: atalman Date: Mon, 13 Feb 2023 10:30:54 -0800 Subject: [PATCH 3/5] Fix py311 tests --- .github/scripts/validate_binaries.sh | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/.github/scripts/validate_binaries.sh b/.github/scripts/validate_binaries.sh index 2b17ba72b..6e3dc33b6 100755 --- a/.github/scripts/validate_binaries.sh +++ b/.github/scripts/validate_binaries.sh @@ -3,24 +3,13 @@ if [[ ${MATRIX_PACKAGE_TYPE} == "libtorch" ]]; then unzip libtorch.zip else #special case for Python 3.11 - if [ $MATRIX_PYTHON_VERSION == '3.11' && ${TARGET_OS} != 'windows']; then - export CPYTHON_VERSIONS=3.11.0 - sudo yum -y install openssl-devel libssl-dev bzip2-devel libffi-devel - sudo yum -y groupinstall "Development Tools" - export PYTHON_PATH="/opt/_internal/cpython-3.11.0/bin" - export PIP_PATH="${PYTHON_PATH}/pip" - export PIP_INSTALLATION="${MATRIX_INSTALLATION/pip3/"$PIP_PATH"}" - export WITH_OPENSSL="/opt/openssl" - ./common/install_cpython.sh - eval ${PYTHON_PATH}/python --version - eval ${PIP_INSTALLATION} - eval ${PYTHON_PATH}/python ./test/smoke_test/smoke_test.py --package torchonly - #special case for Python 3.11 - elif [ $MATRIX_PYTHON_VERSION == '3.11' && ${TARGET_OS} == 'windows']; then + if [[ ${MATRIX_PYTHON_VERSION} == '3.11' ]]; then conda create -y -n ${ENV_NAME} python=${MATRIX_PYTHON_VERSION} conda activate ${ENV_NAME} eval $MATRIX_INSTALLATION eval ${PYTHON_PATH}/python ./test/smoke_test/smoke_test.py --package torchonly + conda deactivate + conda env remove -n ${ENV_NAME} else # Special case Pypi installation package, only applicable to linux nightly CUDA 11.7 builds, wheel package From fdb0b75a7bcd6c0946b830bd2ff64603602f88b7 Mon Sep 17 00:00:00 2001 From: atalman Date: Mon, 13 Feb 2023 10:41:37 -0800 Subject: [PATCH 4/5] fix python calling --- .github/scripts/validate_binaries.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/scripts/validate_binaries.sh b/.github/scripts/validate_binaries.sh index 6e3dc33b6..f11cd43ab 100755 --- a/.github/scripts/validate_binaries.sh +++ b/.github/scripts/validate_binaries.sh @@ -7,7 +7,7 @@ else conda create -y -n ${ENV_NAME} python=${MATRIX_PYTHON_VERSION} conda activate ${ENV_NAME} eval $MATRIX_INSTALLATION - eval ${PYTHON_PATH}/python ./test/smoke_test/smoke_test.py --package torchonly + python ./test/smoke_test/smoke_test.py --package torchonly conda deactivate conda env remove -n ${ENV_NAME} else From f0d90736875f5cdfa1e714a7353f56e74724048c Mon Sep 17 00:00:00 2001 From: atalman Date: Mon, 13 Feb 2023 11:46:13 -0800 Subject: [PATCH 5/5] Revert "Nightly binaries" This reverts commit cbf80ca5fdb8a2fce5552591ebe0f60dd87d04fe. --- .github/workflows/validate-nightly-binaries.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/validate-nightly-binaries.yml b/.github/workflows/validate-nightly-binaries.yml index 32c6781ba..c252e0433 100644 --- a/.github/workflows/validate-nightly-binaries.yml +++ b/.github/workflows/validate-nightly-binaries.yml @@ -32,3 +32,4 @@ jobs: with: channel: nightly os: all + limit-win-builds: enable