Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Inaccurate and incomplete documentation for SingleTaskMultiFidelityGP #2403

Open
esantorella opened this issue Jun 29, 2024 · 0 comments

Comments

@esantorella
Copy link
Member

  • The docstring for linear_truncated and the class docstring describe what the behavior would be if the default were linear_truncated=False. However, the default is True. The model uses a LinearTruncatedFidelityKernel, which isn't described at all.
  • It is not clear how data fidelities are to be interpreted. Does a higher number indicate higher fidelity? Can they lie outside [0, 1]? Do they have a cardinal or ordinal interpretation?

This came up in #2393 , and I spent a while myself trying to understand how fidelities should be specified and how they affect the kernel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant