Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intersphinx Mapping Request #1464

Open
madeline-scyphers opened this issue Oct 26, 2022 · 1 comment
Open

Intersphinx Mapping Request #1464

madeline-scyphers opened this issue Oct 26, 2022 · 1 comment
Labels
documentation enhancement New feature or request

Comments

@madeline-scyphers
Copy link

madeline-scyphers commented Oct 26, 2022

🚀 Feature Request

I am working on a project that uses sphinx to build the docs. We use intersphinx to cross link to other projects and we would like to link to Botorch for type hints and other resources. Because in Botorch's docs scripts, after you build your docs with sphinx, you copy the html files for docusaurus and then the build doesn't have access to the generated objects.inv the gives the inventory of objects for intersphinx linking. Without it, you can't do the intersphinx mapping.

Motivation

Is your feature request related to a problem? Please describe.

Sphinx is widely used as the de facto documentation tool in python, and with it comes the great ability to automatically add non hardcoded links to other people's source code. When people move a class to a different module, your link doesn't break. Botorch already builds its docs with Sphinx, but because it uses docusaurus instead of html templates, you remove the files from sphinx, removing some of the benefits that other libraries might get.

Pitch

Describe the solution you'd like

I am not sure if it would be possible, but maybe if you also copy the objects.inv over as well. It usually goes in the same folder as your index.html file, which is usually in the created _build directory in sphinx, but that directory isn't there, so if you all did do this, maybe where index.html is, so in the api folder in the gh_pages branch.

Describe alternatives you've considered
You could probably get the same website with a custom sphinx html template instead of docusaurus.

Potentially

Additional context

You can see here a way to check if the intersphinx mapping works from command line at the bottom of this page

@madeline-scyphers madeline-scyphers added the enhancement New feature or request label Oct 26, 2022
@madeline-scyphers madeline-scyphers changed the title [Feature Request] Intersphinx Mapping Request Oct 26, 2022
madeline-scyphers added a commit to madeline-scyphers/boa that referenced this issue Oct 26, 2022
Add docutils func that adds a reference to the relative
__init__.py of all files __doc__ in each submodule

change sphinx configuration to be nitpicky which revealed a bunch
of broken sphinx links which were then fixed (except ax and
botorch links which can't be fixed right now because
they don't build sphinx in a normal way.
see facebook/Ax#1227
and see pytorch/botorch#1464
for more info on when ax and botroch can be linked).

Add more docstrings
@Balandat
Copy link
Contributor

Our setup is pretty much the same as Ax's, so let's move the discussions of the technical aspects of this to facebook/Ax#1227.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants