From c3ebf3ff061d12a98edb26729c2fccfb7c304d3d Mon Sep 17 00:00:00 2001 From: Jane Xu Date: Fri, 13 Dec 2024 09:13:56 -0800 Subject: [PATCH] listen to xu's advice with . /home/janeyx/miniconda3/etc/profile.d/conda.sh --- .github/workflows/userbenchmark-regression-detector.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/userbenchmark-regression-detector.yml b/.github/workflows/userbenchmark-regression-detector.yml index 526814df3..09c6657db 100644 --- a/.github/workflows/userbenchmark-regression-detector.yml +++ b/.github/workflows/userbenchmark-regression-detector.yml @@ -34,16 +34,19 @@ jobs: - name: Install TorchBench run: | set -x + . ${HOME}/miniconda3/etc/profile.d/conda.sh pushd benchmark # only install the subset of models currently running. python install.py BERT_pytorch DALLE2_pytorch hf_GPT2_large hf_T5_large resnet50 timm_vision_transformer_large yolov3 - name: Print torch.version.git_version run: | set -x + . ${HOME}/miniconda3/etc/profile.d/conda.sh python -c "import torch; print(torch.version.git_version)" - name: Run optim user benchmark run: | set -x + . ${HOME}/miniconda3/etc/profile.d/conda.sh # remove old results if [ -d benchmark-output ]; then rm -Rf benchmark-output; fi pushd benchmark @@ -56,6 +59,8 @@ jobs: - name: Detect potential regressions continue-on-error: true run: | + set -x + . ${HOME}/miniconda3/etc/profile.d/conda.sh pushd benchmark RESULTS=($(find ${PWD}/../benchmark-output -name "metrics-*.json" -maxdepth 2 | sort -r)) # TODO: the following assumes only one metrics-*.json is found. It will keep @@ -77,6 +82,7 @@ jobs: - name: Upload result jsons to Scribe and S3 run: | pushd benchmark + . ${HOME}/miniconda3/etc/profile.d/conda.sh RESULTS=($(find ${PWD}/../benchmark-output -name "metrics-*.json" -maxdepth 2 | sort -r)) echo "Uploading result jsons: ${RESULTS}" for r in ${RESULTS[@]}; do @@ -91,8 +97,10 @@ jobs: - name: Finally, error if errors.txt exists if: always() run: | + set -x # Do not error earlier as we want all artifacts and regressions to be reported first # TODO: potentially move errors.txt to benchmark-output so it gets uploaded to S3 + . ${HOME}/miniconda3/etc/profile.d/conda.sh pushd benchmark if [ -e errors.txt ]; then cat errors.txt && exit 1; fi - name: Remove conda environment