-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_audio_backends platform independent #554
Comments
It would be nice if it can detect which backend is available at run time. Also we need to document which one is the default backend. |
Yes. In some sense and depending on the definition of run time, this is already the case, see here and here. There's also a partial discussion of backend dispatch in #425.
The default backend for torchaudio has been sox. torchaudio only officially support macos and linux. We do not officially support windows, but there the default is soundfile, see #425 for discussion. |
🐛 Bug
The constant _audio_backends is referenced by BACKENDS in the common utilities of the test folder. test_batch_mfcc is skipped if the 'sox' key is not present in that constant, but it always is. That means this test will be executed in environments where the package may not exist.
To Reproduce
Steps to reproduce the behavior:
python test/test_batch_consistency.py TestTransform.test_batch_mfcc
I can provide more detailed information if required.
Expected behavior
The test should be skipped if sox is not available.
Environment
Additional context
The text was updated successfully, but these errors were encountered: