You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #821, we improved the dataset tests to work on mocked files. In these changes, we applied the pattern to create mock dataset in setUpClass. As we keep improving the test for dataset, the setUpClass gets cluttered and became harder to grasp what's going on, so we should refactor the pattern.
In #1126 we extracted the dataset mocking part into a separate function. We can apply the same pattern to the other tests too. In the end, the initialization should look as simple as,
Additionally, for CommonVoice, the mock part is extracted, but there are two helper functions what are very similar each other, so we can refactor that part too.
In #821, we improved the dataset tests to work on mocked files. In these changes, we applied the pattern to create mock dataset in
setUpClass
. As we keep improving the test for dataset, thesetUpClass
gets cluttered and became harder to grasp what's going on, so we should refactor the pattern.In #1126 we extracted the dataset mocking part into a separate function. We can apply the same pattern to the other tests too. In the end, the initialization should look as simple as,
with extracted helper function that creates mock data and returns the expected data.
Additionally, for CommonVoice, the mock part is extracted, but there are two helper functions what are very similar each other, so we can refactor that part too.
The text was updated successfully, but these errors were encountered: