Temporary fix for QAT quantizer when linear layer bias is True #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1087
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b6982c0 with merge base 6ea36c5 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
Hi @elfisworking, thanks for fixing this. Changes look great! Would you mind adding a test in |
andrewor14
reviewed
Oct 16, 2024
| @@ -617,7 +617,7 @@ def _replace_linear_int4( | |||
| copy_weights: bool = False, | |||
| ): | |||
| for name, child in module.named_children(): | |||
| if isinstance(child, nn.Linear) and (skip_layer_func is None or not skip_layer_func(child.weight)): | |||
| if isinstance(child, nn.Linear) and child.bias is None and (skip_layer_func is None or not skip_layer_func(child.weight)): | |||
There was a problem hiding this comment.
can you also add a TODO: support linear bias (here and L982)
Signed-off-by: yumin <[email protected]>
|
test has been added |
andrewor14
approved these changes
Oct 17, 2024
|
Thanks @elfisworking, merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issue: Int8DynActInt4WeightQATQuantizer doesn't support qwen series #1080