Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[Feature] Add sample tensor field to Input class #1544

Closed
gs-olive opened this issue Dec 12, 2022 · 3 comments
Closed

✨[Feature] Add sample tensor field to Input class #1544

gs-olive opened this issue Dec 12, 2022 · 3 comments
Assignees
Labels
component: api Issues re: API (both TRTorch and future pytorch integration) feature request New feature or request

Comments

@gs-olive
Copy link
Collaborator

Phase 2 of RFC #1425

See RFC for details.

@gs-olive gs-olive added the feature request New feature or request label Dec 12, 2022
@ncomly-nvidia ncomly-nvidia added the component: api Issues re: API (both TRTorch and future pytorch integration) label Dec 13, 2022
@narendasan
Copy link
Collaborator

@gs-olive Is this not already supported via the top level api? Does the internal Input need access to a sample tensor?

@gs-olive
Copy link
Collaborator Author

The top-level API does support sample tensor inputs, but it only uses them to parse fields including shapes and data types. The intent of the original RFC was to allow these sample inputs to be propagated through to the partitioning phase and used as inputs for the dry-run, similar to torch.jit.trace() semantics. At this time, since input tensor domains are currently supported as of PR #1537, it may not be worth the additional effort to pass full Tensors from Python to C++ for the dry-run, as the benefit of this could be marginal above specifying an input domain. Open to thoughts on this.

@gs-olive
Copy link
Collaborator Author

After discussion, RFC #1425 has been marked as Implemented due to PR #1537 and this issue will be closed for now.

@gs-olive gs-olive closed this as not planned Won't fix, can't repro, duplicate, stale Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: api Issues re: API (both TRTorch and future pytorch integration) feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants