Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch color constants to RGBA #1422

Closed
3 tasks done
pushfoo opened this issue Dec 2, 2022 · 4 comments · Fixed by #1425
Closed
3 tasks done

Switch color constants to RGBA #1422

pushfoo opened this issue Dec 2, 2022 · 4 comments · Fixed by #1425

Comments

@pushfoo
Copy link
Member

pushfoo commented Dec 2, 2022

Enhancement request:

What should be added/changed?

  • Make all color constants in arcade.color into RGBA constants
  • Make all color constants in arcade.csscolor into RGBA constants
  • Add a TRANSPARENT_BLACK constant to arcade.color

What would it help with?

  1. Provide better immediate-term support for sprite generation with Pillow or drawing into contexts
  2. Set the stage for future sprite generation API improvements
  3. Make tests for Build improved screenshot API #1342 and other functionality cleaner

This is also a chore einarf and Clepto agreed should be done months ago

@einarf
Copy link
Member

einarf commented Dec 2, 2022

I have already made them into RGBA in my branch
https://github.com/pythonarcade/arcade/blob/texture-revamp/arcade/color/__init__.py
https://github.com/pythonarcade/arcade/blob/texture-revamp/arcade/csscolor/__init__.py

@pushfoo
Copy link
Member Author

pushfoo commented Dec 2, 2022

How long till that gets merged? I'd like to add some more constants to arcade.color and revamp the docstring for arcade.csscolor afterward.

@einarf
Copy link
Member

einarf commented Dec 2, 2022

Think we can get away with cherry picking that commit into development. I can look at that a bit later today

@einarf
Copy link
Member

einarf commented Dec 2, 2022

#1423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants