Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warnings: New arguments to catch_warnings() #7685

Merged
merged 3 commits into from
Apr 26, 2022
Merged

warnings: New arguments to catch_warnings() #7685

merged 3 commits into from
Apr 26, 2022

Conversation

JelleZijlstra
Copy link
Member

@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood
Copy link
Member

Is it worth adding a comment to remind people to keep the signature of warnings.catch_warnings and warnings.simplefilter in sync?

@JelleZijlstra
Copy link
Member Author

Seems like overkill to me, and they don't match perfectly anyway (action is | None here).

@AlexWaygood AlexWaygood merged commit ac2b24c into master Apr 26, 2022
@AlexWaygood AlexWaygood deleted the JelleZijlstra-patch-3 branch April 26, 2022 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JelleZijlstra @AlexWaygood