Make fromkeys() take an Iterable instead of a sequence [REVERTED] #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm... Either this one or the previous one (#604) caused breakage on |
|
Oh. It's python/mypy#328 |
gvanrossum
pushed a commit
that referenced
this pull request
Oct 15, 2016
Reason: python/mypy#328 * Revert "Make fromkeys() take an Iterable instead of a sequence. (#605)" This reverts commit 66e8d4a. * Revert "Make dict.fromkeys() a classmethod (which it is). (#604)" This reverts commit 26dfcb6. * Add an explanation for fromkeys() being a staticmethod.
gvanrossum
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This, too, came up in python/mypy#2254 -- thanks @rwbarton!)
UPDATE: This was rolled back.