Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a Protocol as the argument for io.TextIOWrapper #10229

Closed
wants to merge 11 commits into from
Closed

Use a Protocol as the argument for io.TextIOWrapper #10229

Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
677c42d
Use a Protocol as the argument for io.TextIOWrapper
JelleZijlstra May 28, 2023
7643545
Ignore incompatible type
JelleZijlstra May 28, 2023
4aefbea
Try Sebastian's idea
JelleZijlstra May 30, 2023
dcad196
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 30, 2023
5131054
Fix a mypy warning, add detach()
srittau Jun 6, 2023
51f089b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 6, 2023
d565a9f
Merge branch 'main' into tiow
JelleZijlstra Jun 8, 2023
a2f9360
Merge branch 'main' into tiow
srittau Jun 14, 2023
355595e
Back to a Protocol
JelleZijlstra Jun 16, 2023
998ac18
Merge branch 'main' into tiow
JelleZijlstra Feb 14, 2024
aafa7ed
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions stdlib/io.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,15 +147,15 @@ class TextIOBase(IOBase):
class TextIOWrapper(TextIOBase, TextIO): # type: ignore[misc] # incompatible definitions of write in the base classes
def __init__(
self,
buffer: IO[bytes],
buffer: BufferedIOBase,
encoding: str | None = ...,
errors: str | None = ...,
newline: str | None = ...,
line_buffering: bool = ...,
write_through: bool = ...,
) -> None: ...
@property
def buffer(self) -> BinaryIO: ...
def buffer(self) -> BufferedIOBase: ... # type: ignore[override]
@property
def closed(self) -> bool: ...
@property
Expand All @@ -178,6 +178,7 @@ class TextIOWrapper(TextIOBase, TextIO): # type: ignore[misc] # incompatible d
def writelines(self, __lines: Iterable[str]) -> None: ... # type: ignore[override]
def readline(self, __size: int = -1) -> str: ... # type: ignore[override]
def readlines(self, __hint: int = -1) -> list[str]: ... # type: ignore[override]
def detach(self) -> BufferedIOBase: ... # type: ignore[override]
def seek(self, __cookie: int, __whence: int = 0) -> int: ... # stubtest needs this

class StringIO(TextIOWrapper):
Expand Down