Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ipaddress stub in third_party/2 ? #3309

Closed
jlaine opened this issue Oct 5, 2019 · 2 comments
Closed

Provide ipaddress stub in third_party/2 ? #3309

jlaine opened this issue Oct 5, 2019 · 2 comments

Comments

@jlaine
Copy link
Contributor

jlaine commented Oct 5, 2019

For Python 3 we have stubs for the stdlib's ipaddress module. For Python 2, ipaddress is not part of the standard library but is available as third party package, much like enum.

Is the proper way to handle this to copy over ipaddress to third_party/2?

@JelleZijlstra
Copy link
Member

Yes, assuming the backport's API is the same as the one in the stdlib. We could add a test in check_consistent.py to ensure that the two copies stay in sync.

@jlaine
Copy link
Contributor Author

jlaine commented Oct 18, 2019

This was fixed in 57384ce

@jlaine jlaine closed this as completed Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants