Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Replace regexes in pre-commit config with check-peps.py #4063

Open
JelleZijlstra opened this issue Oct 16, 2024 · 0 comments
Open

Meta: Replace regexes in pre-commit config with check-peps.py #4063

JelleZijlstra opened this issue Oct 16, 2024 · 0 comments

Comments

@JelleZijlstra
Copy link
Member

Currently, we have a number of rather complex regexes in .pre-commit-config.yaml that validate various invariants in the PEPs. We also have a script check-peps.py that does the same thing in Python. Not only does that script not require long incomprehensible regexes, it also provides much better error messages to users.

So we should ditch the regexes and just use check-peps.py. @hugovk tells me that when we tried, there was some issue with Windows (#4061 (comment)). Let's figure out what the issue was and fix it, so we can fully remove the regexes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant