Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dict unpacking type checks don't consider **kwargs #17642

Closed
dinatamas opened this issue Aug 4, 2024 · 3 comments
Closed

Dict unpacking type checks don't consider **kwargs #17642

dinatamas opened this issue Aug 4, 2024 · 3 comments
Labels
bug mypy got something wrong topic-type-context Type context / bidirectional inference

Comments

@dinatamas
Copy link

dinatamas commented Aug 4, 2024

Bug Report:

In the below example (playground gist), mypy behaves differently with respect to **kwargs:

def func(x: bool = False, **kwargs):
    print(x, kwargs)

# This is accepted by mypy.
func(y="y")

# This is flagged by mypy.
data = {"y": "y"}
func(**data)

The error is Argument 1 to "func" has incompatible type "**dict[str, str]"; expected "bool" [arg-type]. This is incorrect because the function has **kwargs, so the dict / function call should be considered type correct.

Your Environment:

  • Mypy version used: latest (1.11.1)
  • Mypy command-line flags: -
  • Mypy configuration options from mypy.ini (and other config files): -
  • Python version used: 3.12
@JelleZijlstra JelleZijlstra added the topic-type-context Type context / bidirectional inference label Oct 15, 2024
@dinatamas
Copy link
Author

dinatamas commented Dec 1, 2024

I have overlooked that data may specify x.

def func(x: bool = False, **kwargs):
    print(x, kwargs)

data = {"x": "a"}
func(**data)  # warning

Since mypy has no way to know the content of the dictionary (unless it's a TypedDict or frozendict), it is correct to flag this function call.

If func only expects strings, mypy accepts this.

def func(x: str = "text", **kwargs):
    print(x, kwargs)

data = {"x": "a", "y": "b"}
func(**data)  # ok

It also accepts this if x is explicitly provided.

def func(x: bool = False, **kwargs):
    print(x, kwargs)

data = {"y": "b"}
func(x=True, **data)  # ok

@dinatamas
Copy link
Author

Hence mypy's behavior is correct and I'm closing this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug mypy got something wrong topic-type-context Type context / bidirectional inference
Projects
None yet
Development

No branches or pull requests

3 participants