Mypy 1.4 Release Planning

[jhance]

I'm planning to make a 1.4 release around early July. (This is actually meant to be the June release but it is delayed).

Please post here any issues you'd like to see fixed in the release, or PRs you'd like to have merged. The release branch is available as release-1.4.

[JelleZijlstra]

I hope you mean the 1.4 release :)

[cdce8p]

Update: Fixed with #15383

The mypy wheel build seems to be broken atm. It seems to be platform specific to x86_64, arm64 isn't affected. More details: #15283 (comment)

Cross posting it here to keep track.

[JukkaL]

Updated the version number.

[jhance]

Hmm, I'm not sure how that happened. I suspect I copied the issue template from the oldest link in our table, rather than the newest one, and then incremented that without thinking if the version number made sense.

[AlexWaygood]

• @A5rocks's PR here purports to fix two open crash reports: Reconsider constraints involving parameter specifications #15272
• It's not urgent, but I'd love it if somebody could take a look at my PR here. It's been open >2 months now, it's not too complicated, and the primer results look good: Improve handling of attribute access on class objects #14988

[AlexWaygood]

Also, just to note: #15161 caused a LiteralString-related regression for typeshed that still exists on the master branch. I reported the regression here immediately after the PR was merged: #15161 (comment).

It looks like it's probably a typeshed-specific problem, and we can definitely just work around it in typeshed if we need to. So it's not a huge issue by any means. Just thought I'd mention it anyway, though!

[ilevkivskyi]

I am going to work on some recently reported crashes. I will post them here as soon as I have a fix, the first will be #15351

[ilevkivskyi]

And here is a fix for this crash #15402

[ilevkivskyi]

And here is a fix for another crash #15403

[ilevkivskyi]

And yet another crash fix #15404

[hauntsaninja]

Two crash fixes of mine that didn't make the branch: #15392 #15399

[ilevkivskyi]

And here is yet another crash fix #15407

[cdce8p]

Would love to see #15413 included. That change alone removes 23 unnecessary type: ignore comments in Home Assistant.

[ilevkivskyi]

I think these two batches are good candidates for cherry-picking:

• These three docs: ref redirector #15432, Use consistent anchors for error codes #15435, Fix readthedocs build #15437 add support for stable error code docs links like https://mypy.readthedocs.io/en/latest/_refs.html#code-union-attr etc. It would be great to have them in /stable not just in /latest.
• Fix dmypy run on Windows #15429 and possibly Fix re-added file with errors in mypy daemon #15440. As they may significantly improve mypy daemon experience for VS Code users.

[ilevkivskyi]

Oh and one more things, it seems these error codes do not have documentation (at least neither my script nor me have found it):

        known_missing = {
            # TODO: fix these before next release
            "annotation-unchecked",
            "empty-body",
            "possibly-undefined",
            "str-format",
            "top-level-await",
        }

[intgr]

@ymyzk Can you please add mypy 1.4.0 to mypy-play.net?

[ymyzk]

@intgr It should be available on mypy Playground now: ymyzk/mypy-playground#388

[hauntsaninja]

Thanks for all the work! Regression for asyncio here #15489 with a potential fix here #15491. This will need a hotfix release (I can make it if you're busy, just let me know)

[ilevkivskyi]

Wait, so this is already released? Is it early July already? What was the point of not including the stable error code links in the release?

[JukkaL]

This was the postponed May mypy release. I think stable error code links arrived too late in the release process, but there will be a 1.5 release in July (targeting early July). @svalentin is the RM for 1.5.

[cdce8p]

In case there is a 1.4.1 release. These fix the wheel build

• Switch PEP 561 tests to a different build backend #15451
• Fix PEP 561 - editable install - test case #15493

Fix for typing_extensions dependency issue

• Bump typing_extensions dependency #15488

[AlexWaygood]

You'll probably also want to cherry-pick this, if there is a 1.4.1 release -- our test suite was very broken by the pytest release earlier today:

• Unbreak CI #15505

[hauntsaninja]

I've cherry picked the following to the 1.4 release branch:

Fix for async type checking regression

f36ea01e9 (HEAD -> release-1.4) Shantanu: Fix async iterator body stripping (#15491)      (Fri Jun 23 18:12:13 2023)

A fix for typeshed (reverts a PR that fixed another problem that only manifested on typeshed)

ba7887be3             Shantanu: Revert "Fix spurious errors on builtins.open (#15161)" (#15508) (Fri Jun 23 18:12:10 2023)

Docs changes:

16fe5da0b      Ivan Levkivskyi: Fix readthedocs build (#15437)                            (Fri Jun 23 17:54:30 2023)
9b327d12b      Ivan Levkivskyi: Use consistent anchors for error codes (#15435)           (Fri Jun 23 17:54:26 2023)
32abe0210          Ilya Priven: docs: ref redirector (#15432)                             (Fri Jun 23 17:54:14 2023)

Fixes for CI and wheel build:

e5a5b33e1         Alex Waygood: Unbreak CI (#15505)                                       (Fri Jun 23 17:39:48 2023)
81d01aa0b         Marc Mueller: Fix PEP 561 editable install test case (#15493)           (Fri Jun 23 17:39:30 2023)
eba351e40         Marc Mueller: Add pip as test requirement for PEP 660 editable installs (#15482) (Fri Jun 23 17:39:26 2023)
9faffe87c         Marc Mueller: Bump typing_extensions dependency (#15488)                (Fri Jun 23 17:39:21 2023)
7871ed92a             Shantanu: Switch PEP 561 tests to a different build backend (#15451) (Fri Jun 23 17:39:16 2023)
87ddfeeef         hauntsaninja: Add back +dev to version                                  (Fri Jun 23 17:38:45 2023)

Hopefully this is all good. If I don't hear anything, I'll make a patch release this weekend (really excited to have the 1.4 speedups at work, but the async thing is a blocker)

[hauntsaninja]

I've released mypy 1.4.1

[Avasam]

Was #15429 actually included in 1.4.1 ? I still have the issue where --ignore-missing-imports causes

Restarting: configuration changed
Daemon stopped
Daemon started

[svalentin]

I don't see it in https://github.com/python/mypy/commits/release-1.4
It will definitely be in release 1.5

[intgr]

The mypy website https://www.mypy-lang.org/ still hasn't been updated to list version 1.4.