From 97e7f3e8af8ab0c1f00c9c3f3f71e828210dc3a2 Mon Sep 17 00:00:00 2001 From: Alex Waygood Date: Tue, 25 Apr 2023 12:23:07 -0600 Subject: [PATCH] Don't run flake8 twice in CI (#15129) --- .github/workflows/test.yml | 3 +++ .pre-commit-config.yaml | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index ed0c82ef5fa1..13cb2e7fa8f0 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -93,6 +93,9 @@ jobs: arch: x64 os: windows-latest toxenv: type + # We also run these checks with pre-commit in CI, + # but it's useful to run them with tox too, + # to ensure the tox env works as expected - name: Formatting with Black + isort and code style with flake8 python: '3.7' arch: x64 diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 566e31d77017..8dbf2c0cc01d 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -14,3 +14,7 @@ repos: additional_dependencies: - flake8-bugbear==22.12.6 # must match test-requirements.txt - flake8-noqa==1.3.0 # must match test-requirements.txt + +ci: + # We run flake8 as part of our GitHub Actions suite in CI + skip: [flake8]