Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy tests failing on Windows only #478

Closed
jaraco opened this issue Dec 1, 2023 · 1 comment
Closed

Mypy tests failing on Windows only #478

jaraco opened this issue Dec 1, 2023 · 1 comment

Comments

@jaraco
Copy link
Member

jaraco commented Dec 1, 2023

In this run and others, the mypy test is failing with:

================================== FAILURES ===================================
_____________________________ tests\test_main.py ______________________________
409: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]

On the non-Windows tests, the same message is shown as a warning:

=============================== warnings summary ===============================
tests/test_main.py::mypy
  /home/runner/work/importlib_metadata/importlib_metadata/.tox/py/lib/python3.11/site-packages/pytest_mypy.py:212: MypyWarning: 
  409: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
    warnings.warn("\n" + "\n".join(errors), MypyWarning)  # pragma: no cover

Dear god, why?

@jaraco jaraco closed this as completed in dfa7fed Dec 1, 2023
@jaraco
Copy link
Member Author

jaraco commented Dec 1, 2023

For what it's worth, I don't encounter the error when testing on my Windows machine, so the difference between Windows and non-Windows appears to be in how the CI is configured... which seems really unlikely, given that tox filters most environment variables. Doesn't matter - the warning and error are both addressed by adding more redundant typing info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant