Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin sphinx-lint to fix the CI #955

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 6, 2022

Between PR #954 being opened (CI passed) and merged 25 minutes later (CI failed), a new release of sphinx-lint came out with differing checks.

Let's pin it to get the CI green, and I'll open an issue to upgrade and fix the issues.

@arhadthedev
Copy link
Member

new release of sphinx-lint came out with differing checks.

Or with bugs. From a code diff of python/cpython#97962:

sphinx-lint 0.6.2 yields many default role errors due to the new regular expression used for default role detection, so we don't use the version until the errors are fixed.

@AA-Turner
Copy link
Member

Or with bugs. From a code diff of python/cpython#97962:

... the errors are fixed.

I meant the errors in CPython's reStructuredText sources in that comment, I'm assuming the changes in sphinx-lint are correct. I haven't checked either, though.

A

@JelleZijlstra JelleZijlstra merged commit 1e315c0 into python:main Oct 6, 2022
@JelleZijlstra
Copy link
Member

I didn't check in detail but the amount of errors in CI does suggest a bug in sphinx-lint.

@hugovk hugovk deleted the pin-sphinx-lint branch October 6, 2022 18:25
@hugovk
Copy link
Member Author

hugovk commented Oct 6, 2022

Yes, reported here: sphinx-contrib/sphinx-lint#46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants