Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions for adding a new definition to the limited API don't work on platforms without make #1102

Closed
AlexWaygood opened this issue May 30, 2023 · 2 comments · Fixed by #1103

Comments

@AlexWaygood
Copy link
Member

AlexWaygood commented May 30, 2023

Describe the bug

In the devguide here, it states:

Regenerate the autogenerated files using make regen-limited-abi. On platforms without make, run this command directly:

./python ./Tools/scripts/stable_abi.py --generate-all ./Misc/stable_abi.toml

I'm using a platform without make, so I went for the second option. Unfortunately, there's no such script! Tools/scripts/stable_api.py doesn't exist in the CPython repo currently. As such, the instructions didn't work.

Expected behavior

I expected the instructions to work

@encukou
Copy link
Member

encukou commented May 30, 2023

Ugh. Yes, looks like it was moved to Tools/build/stable_abi.py in python/cpython#97963

There might be more:

$ git grep Tools/scripts
developer-workflow/c-api.rst:381:     ./python ./Tools/scripts/stable_abi.py --generate-all ./Misc/stable_abi.toml
developer-workflow/c-api.rst:388:    ./python ./Tools/scripts/stable_abi.py --all ./Misc/stable_abi.toml
internals/interpreter.rst:49:Some code objects are pre-loaded into the interpreter using ``Tools/scripts/deepfreeze.py``, which writes ``Python/deepfreeze/deepfreeze.c``.
testing/run-write-tests.rst:94:You can also execute the ``Tools/scripts/run_tests.py`` script as  found in a

@encukou
Copy link
Member

encukou commented May 30, 2023

False alarm: internals/interpreter.rst is 3.11-specific, and Tools/scripts/run_tests.py still exists.

#1103 should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants