Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-99103: Normalize specialized traceback anchors against the current line #99145

Merged
merged 2 commits into from
Nov 12, 2022
Merged

gh-99103: Normalize specialized traceback anchors against the current line #99145

merged 2 commits into from
Nov 12, 2022

Conversation

isidentical
Copy link
Member

@isidentical isidentical commented Nov 5, 2022 •
edited by miss-islington
Loading

@bedevere-bot bedevere-bot mentioned this pull request Nov 5, 2022
Closed
@isidentical isidentical added the needs backport to 3.11 only security fixes label Nov 5, 2022
pablogsal
pablogsal reviewed Nov 8, 2022
View reviewed changes
Python/traceback.c Outdated Show resolved Hide resolved
pablogsal
pablogsal reviewed Nov 8, 2022
View reviewed changes
Lib/traceback.py Outdated Show resolved Hide resolved
pablogsal
pablogsal reviewed Nov 8, 2022
View reviewed changes
Lib/traceback.py Outdated Show resolved Hide resolved
pablogsal
pablogsal approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I left a bunch of small nits. Thanks for fixing this :)

@isidentical
Copy link
Member Author

Thank you @pablogsal, they all should be addressed now!

@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅.

@miss-islington miss-islington merged commit 57be545 into python:main Nov 12, 2022
@miss-islington
Copy link
Contributor

Thanks @isidentical for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @isidentical, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 57be5459593bbd09583317ebdafc4d58ae51dbf4 3.11

@miss-islington miss-islington self-assigned this Nov 12, 2022
isidentical added a commit to isidentical/cpython that referenced this pull request Nov 12, 2022
@isidentical
[3.11] pythongh-99103: Normalize specialized traceback anchors agains…
d946e7a 
…t the current line (pythonGH-99145)

Automerge-Triggered-By: GH:isidentical.
(cherry picked from commit 57be545)

Co-authored-by: Batuhan Taskaya <[email protected]>
pablogsal pushed a commit that referenced this pull request Nov 21, 2022
@isidentical
[3.11] gh-99103: Normalize specialized traceback anchors against the …
a3480ec 
…current line (#99423)

[3.11] gh-99103: Normalize specialized traceback anchors against the current line (GH-99145)

Automerge-Triggered-By: GH:isidentical.
(cherry picked from commit 57be545)

Co-authored-by: Batuhan Taskaya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

@ammaraskar ammaraskar Awaiting requested review from ammaraskar

Assignees

@miss-islington miss-islington

Labels
needs backport to 3.11 only security fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isidentical @miss-islington @pablogsal @bedevere-bot