Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix backtick errors found by sphinx-lint #97998

Merged
merged 4 commits into from
Oct 7, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 6, 2022

No description provided.

Doc/howto/logging.rst Outdated Show resolved Hide resolved
Doc/library/concurrent.futures.rst Outdated Show resolved Hide resolved
Doc/library/concurrent.futures.rst Outdated Show resolved Hide resolved
Doc/library/dis.rst Outdated Show resolved Hide resolved
Doc/library/hashlib.rst Outdated Show resolved Hide resolved
Copy link
Member Author

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ... for True/False/None

Edit: oops, this was meant to be the review commit message! The buttons are next to each other... Will try again!

hugovk and others added 2 commits October 7, 2022 02:07
Co-authored-by: Ezio Melotti <[email protected]>
Co-authored-by: Ezio Melotti <[email protected]>
@ambv ambv merged commit fa2d43e into python:main Oct 7, 2022
@hugovk hugovk deleted the fix-sphinx-lint branch October 7, 2022 01:02
@CAM-Gerlach
Copy link
Member

I can manually backport the changes (minus the Sphinx-lint for 3.10) since they do fix genuine defects and will avoid future merge conflicts when backporting other PRs, and can follow up later with a PR bumping 3.11 and 3.12 to the latest version of Sphinx-Lint (0.6.5, at this writing, which fixes an additional false positive found in the CPython docs that this PR worked around).

@ezio-melotti
Copy link
Member

SGTM. Coordinate on Discord/IRL so that we don't step on each other's toes, and feel free to @mention me on issues/PRs.

@CAM-Gerlach
Copy link
Member

Yup, talked to @hugovk about it—was sitting right next to him IRL yesterday and made sure we didn't duplicate each others' work on the various issues that came up 👍

carljm added a commit to carljm/cpython that referenced this pull request Oct 8, 2022
* main:
  pythongh-86298: Ensure that __loader__ and __spec__.loader agree in warnings.warn_explicit() (pythonGH-97803)
  pythongh-82874: Convert remaining importlib format uses to f-str. (python#98005)
  Docs: Fix backtick errors found by sphinx-lint (python#97998)
  pythongh-97850: Remove deprecated functions from `importlib.utils` (python#97898)
  Remove extra spaces in custom openSSL documentation. (python#93568)
  pythonGH-90985: Revert  "Deprecate passing a message into cancel()" (python#97999)
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
CAM-Gerlach pushed a commit to CAM-Gerlach/cpython that referenced this pull request Oct 17, 2022
Co-authored-by: Ezio Melotti <[email protected]>.
(cherry picked from commit fa2d43e)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-bot
Copy link

GH-98371 is a backport of this pull request to the 3.11 branch.

CAM-Gerlach pushed a commit to CAM-Gerlach/cpython that referenced this pull request Oct 17, 2022
Co-authored-by: Ezio Melotti <[email protected]>.
(cherry picked from commit fa2d43e)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-bot
Copy link

GH-98373 is a backport of this pull request to the 3.10 branch.

ezio-melotti pushed a commit that referenced this pull request Oct 17, 2022
)

Co-authored-by: Ezio Melotti <[email protected]>.
(cherry picked from commit fa2d43e)

Co-authored-by: Hugo van Kemenade <[email protected]>

Co-authored-by: Hugo van Kemenade <[email protected]>
ezio-melotti pushed a commit that referenced this pull request Oct 17, 2022
)

Co-authored-by: Ezio Melotti <[email protected]>.
(cherry picked from commit fa2d43e)

Co-authored-by: Hugo van Kemenade <[email protected]>

Co-authored-by: Hugo van Kemenade <[email protected]>
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
)

Co-authored-by: Ezio Melotti <[email protected]>.
(cherry picked from commit fa2d43e)

Co-authored-by: Hugo van Kemenade <[email protected]>

Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants