Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.11] gh-54781: Relocate and improve NEWS entry for sqlite3 test relocation #95061

Closed

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jul 20, 2022

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Jul 20, 2022
@erlend-aasland erlend-aasland changed the title gh-54781: Add NEWS entry for sqlite3 test relocation [3.11] gh-54781: Add NEWS entry for sqlite3 test relocation Jul 20, 2022
@zware
Copy link
Member

zware commented Jul 20, 2022

The original PR GH-29304 had a NEWS entry now enshrined in Misc/NEWS.d/3.11.0a2.rst. See https://docs.python.org/3.11/whatsnew/changelog.html#id67 (though it does look like it was put in Library rather than Tests).

@erlend-aasland
Copy link
Contributor Author

The original PR GH-29304 had a NEWS entry now enshrined in Misc/NEWS.d/3.11.0a2.rst. See https://docs.python.org/3.11/whatsnew/changelog.html#id67 (though it does look like it was put in Library rather than Tests).

Right; what a mess I'm making here :) Sorry for all the noise. I'll blame the heat 🥵 Let's move it to the Tests category then; that seems like a better fit for that changelog item

@erlend-aasland
Copy link
Contributor Author

PTAL; moved and improved.

@erlend-aasland erlend-aasland changed the title [3.11] gh-54781: Add NEWS entry for sqlite3 test relocation [3.11] gh-54781: Relocate and improve NEWS entry for sqlite3 test relocation Jul 20, 2022
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should be done on main and backported (this NEWS file also exists on main).

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jul 20, 2022

Of course; thanks for the heads-up. See:

@erlend-aasland erlend-aasland deleted the 3.11-sqlite-test-move-news branch July 20, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting core review docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants