Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-29697: Don't use OpenSSL <1.0.2 fallback on 1.1+ #395

Merged
merged 1 commit into from
Mar 2, 2017

Conversation

dstufft
Copy link
Member

@dstufft dstufft commented Mar 2, 2017

Woo, C code! Someone should make sure this is right.

@mention-bot
Copy link

@dstufft, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tiran, @serhiy-storchaka, @Haypo, @vadmium and @berkerpeksag to be potential reviewers.

@kroeckx
Copy link

kroeckx commented Nov 10, 2017

I tried to backport this in the Debian python2.7 package, but this doesn't seem to have any effect. I also can't see a reference to the SSL_CTX_set_tmp_ecdh in /usr/lib/python2.7/lib-dynload/_ssl.x86_64-linux-gnu.so file before or after the patch, so things aren't making sense to me. Can someone help?

@kroeckx
Copy link

kroeckx commented Nov 11, 2017

With a simple test program it actually looks fixed

@tiran
Copy link
Member

tiran commented Nov 13, 2017

SSL_CTX_set_tmp_ecdh is implemented as a macro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants