Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Fix default latex_elements['papersize'] #124525

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Conversation

jfbu
Copy link
Contributor

@jfbu jfbu commented Sep 25, 2024

https://www.sphinx-doc.org/en/master/latex.html#the-latex-elements-configuration-setting

It should be 'letterpaper' or 'a4paper' not 'letter' or 'a4' (not to be confused with PAPER env variable).

The issue was reported at python/docsbuild-scripts#187 (comment).

$ grep -A1 'LaTeX Warning' library.log
LaTeX Warning: Unused global option(s):
    [a4].

📚 Documentation preview 📚: https://cpython-previews--124525.org.readthedocs.build/

https://www.sphinx-doc.org/en/master/latex.html#the-latex-elements-configuration-setting

It should be 'letterpaper' or 'a4paper' not 'letter' or 'a4' (not be
confused with PAPER env variable).
@jfbu
Copy link
Contributor Author

jfbu commented Sep 26, 2024

ping @picnixz

@hugovk hugovk requested a review from AA-Turner September 27, 2024 23:25
@picnixz picnixz added the docs Documentation in the Doc dir label Sep 27, 2024
@AA-Turner AA-Turner changed the title [DOC] Fix default latex_elements['papersize'] Doc: Fix default latex_elements['papersize'] Sep 28, 2024
@AA-Turner AA-Turner added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Sep 28, 2024
@AA-Turner AA-Turner merged commit fae5058 into python:main Sep 28, 2024
32 checks passed
@miss-islington-app
Copy link

Thanks @jfbu for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 28, 2024
https://www.sphinx-doc.org/en/master/latex.htmlGH-the-latex-elements-configuration-setting

It should be 'letterpaper' or 'a4paper' not 'letter' or 'a4'
(not to be confused with PAPER env variable).
(cherry picked from commit fae5058)

Co-authored-by: Jean-François B. <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 28, 2024

GH-124725 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 28, 2024
https://www.sphinx-doc.org/en/master/latex.htmlGH-the-latex-elements-configuration-setting

It should be 'letterpaper' or 'a4paper' not 'letter' or 'a4'
(not to be confused with PAPER env variable).
(cherry picked from commit fae5058)

Co-authored-by: Jean-François B. <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 28, 2024
@bedevere-app
Copy link

bedevere-app bot commented Sep 28, 2024

GH-124726 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 28, 2024
AA-Turner pushed a commit that referenced this pull request Sep 28, 2024
…124726)

Doc: Fix default ``latex_elements['papersize']`` (GH-124525)

https://www.sphinx-doc.org/en/master/latex.htmlGH-the-latex-elements-configuration-setting

It should be 'letterpaper' or 'a4paper' not 'letter' or 'a4'
(not to be confused with PAPER env variable).
(cherry picked from commit fae5058)

Co-authored-by: Jean-François B <[email protected]>
Yhg1s pushed a commit that referenced this pull request Sep 30, 2024
…124725)

Doc: Fix default ``latex_elements['papersize']`` (GH-124525)

https://www.sphinx-doc.org/en/master/latex.htmlGH-the-latex-elements-configuration-setting

It should be 'letterpaper' or 'a4paper' not 'letter' or 'a4'
(not to be confused with PAPER env variable).
(cherry picked from commit fae5058)

Co-authored-by: Jean-François B <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants