gh-117657: Fix some simple races in instrumentation.c #120118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think these should only be called in contexts in which no other thread is currently executing the bytecode -- I don't think we should need atomic stores. I'm a bit concerned that GCC TSan may report spurious warnings, so I've been sticking to clang-18 for local TSan runs to match the CI. |
|
There was a crash in the 3.13 buildbot in |
|
I get the same warnings about those 3 lines on TSAN as well with clang-18.
ISTM we only stop the world in the global events set by Here's an example race by TSAN: |
|
Thanks @Fidget-Spinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 13, 2024
…-120118) * stop the world when setting local events (cherry picked from commit b1b61dc) Co-authored-by: Ken Jin <[email protected]>
|
GH-120444 is a backport of this pull request to the 3.13 branch. |
|
Thanks @Fidget-Spinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 13, 2024
…-120118) * stop the world when setting local events (cherry picked from commit b1b61dc) Co-authored-by: Ken Jin <[email protected]>
Fidget-Spinner
added a commit
that referenced
this pull request
Jun 13, 2024
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
…-120118) * stop the world when setting local events
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…-120118) * stop the world when setting local events
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…-120118) * stop the world when setting local events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other more egregious races are a little trickier.
Also not sure why this only turns up in gcc's tsan but seemingly not in clang's tsan.This turns up in clang-18 TSAN (see below).