-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-117657: Fix data races report by TSAN unicode-hash #119907
Conversation
corona10
commented
Jun 1, 2024
•
edited by bedevere-app
bot
Loading
edited by bedevere-app
bot
- Issue: Make TSAN tests pass with the GIL disabled in free-threaded builds #117657
@colesbury @mpage |
I think there is still a data race, even if it's only reported occasionally. We read and write to cpython/Objects/unicodeobject.c Lines 11391 to 11396 in 90ec19f
|
Thank you for the feedback, I will take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…-119907) (cherry picked from commit 0594a27) Co-authored-by: Donghee Na <[email protected]>
GH-119963 is a backport of this pull request to the 3.13 branch. |