Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-24209: In http.server script, rely on getaddrinfo to bind to preferred address based on the bind parameter. #11767

Merged
merged 8 commits into from
Feb 7, 2019
Merged

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Feb 6, 2019

@jaraco
Copy link
Member Author

jaraco commented Feb 6, 2019

With this patch, I see this behavior:

cpython feature/http-server-bind-ipv6 $ ./python.exe -m http.server --bind localhost                                                                                                     
Serving HTTP on ::1 port 8000 (http://::1:8000/) ...
^C
Keyboard interrupt received, exiting.
cpython feature/http-server-bind-ipv6 $ ./python.exe -m http.server                                                                                                                      
Serving HTTP on :: port 8000 (http://:::8000/) ...
^C
Keyboard interrupt received, exiting.

@jaraco
Copy link
Member Author

jaraco commented Feb 6, 2019

@lisroach Since you reviewed and submitted the last PR on this issue, would you care to comment on or review this also?

@jaraco
Copy link
Member Author

jaraco commented Feb 7, 2019

I'm inclined to proceed with the merge, but happy to iterate further as needed.

@jaraco jaraco merged commit f289084 into python:master Feb 7, 2019
@bedevere-bot
Copy link

@jaraco: Please replace # with GH- in the commit message next time. Thanks!

@jaraco jaraco deleted the feature/http-server-bind-ipv6 branch February 7, 2019 13:23
@rathann
Copy link

rathann commented Mar 21, 2020

Will this be backported to 3.7?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants