gh-117122: Fix pystats after incremental GC changes #117123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdboom
commented
Mar 21, 2024
mdboom
commented
Mar 21, 2024
| @@ -1421,7 +1420,7 @@ gc_collect_increment(PyThreadState *tstate, struct gc_collection_stats *stats) | |||
| gc_set_old_space(gc, gcstate->visited_space); | |||
| increment_size += expand_region_transitively_reachable(&increment, gc, gcstate); | |||
| } | |||
| GC_STAT_ADD(1, objects_queued, region_size); | |||
| GC_STAT_ADD(1, objects_queued, increment_size); | |||
There was a problem hiding this comment.
I don't know if this is correct, but region_size doesn't exist.
There was a problem hiding this comment.
I'm not sure if this make sense anymore. Maybe just drop the "queued" stat?
markshannon
reviewed
Mar 21, 2024
There was a problem hiding this comment.
This is going to conflict with #117120.
Once that's in, I'll review this properly.
| @@ -1421,7 +1420,7 @@ gc_collect_increment(PyThreadState *tstate, struct gc_collection_stats *stats) | |||
| gc_set_old_space(gc, gcstate->visited_space); | |||
| increment_size += expand_region_transitively_reachable(&increment, gc, gcstate); | |||
| } | |||
| GC_STAT_ADD(1, objects_queued, region_size); | |||
| GC_STAT_ADD(1, objects_queued, increment_size); | |||
There was a problem hiding this comment.
I'm not sure if this make sense anymore. Maybe just drop the "queued" stat?
|
Actually, don't worry about the merge conflict. I can fix it in my PR |
I leave that to you, but this stat is new as of #116206 (it's just that it never compiled). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the pystats build after #116206.