Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Bump GitHub Actions #108879

Merged
merged 2 commits into from
Sep 4, 2023
Merged

CI: Bump GitHub Actions #108879

merged 2 commits into from
Sep 4, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Sep 4, 2023 •
edited
Loading

These are all actions/checkout@v3 -> actions/checkout@v4 except one actions/[email protected] -> actions/[email protected] whilst we're at it.

To workaround actions/checkout#1448.

@sobolevn
Copy link
Member

sobolevn commented Sep 4, 2023

CC @Zac-HD for hypothesis failures: https://github.com/python/cpython/actions/runs/6074529494/job/16478809374?pr=108879

sobolevn
sobolevn approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the same problem in mypy.

@sobolevn sobolevn mentioned this pull request Sep 4, 2023
Merged
@Zac-HD
Copy link
Contributor

Zac-HD commented Sep 4, 2023

This is a new health check which warns if the same function object (ie method decorated before being bound) is called with multiple distinct values of self, usually because of inheritance.

We added this check because that can lead to database collisions and in some very rare cases spurious failures, but for CPython and Mypy I'd probably just globally disable the check.

@hugovk
Copy link
Member Author

hugovk commented Sep 4, 2023

@Zac-HD Please could you open a PR to disable it? Thank you!

@sobolevn sobolevn mentioned this pull request Sep 4, 2023
Merged
@ambv ambv merged commit 572678e into python:main Sep 4, 2023
26 of 27 checks passed
@miss-islington
Copy link
Contributor

Thanks @hugovk for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9, 3.10, 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @hugovk and @ambv, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 572678e1f864cb042df6962848a436d84ef7a8a4 3.11

@bedevere-bot
Copy link

GH-108889 is a backport of this pull request to the 3.12 branch.

@miss-islington
Copy link
Contributor

Sorry, @hugovk and @ambv, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 572678e1f864cb042df6962848a436d84ef7a8a4 3.10

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Sep 4, 2023
@miss-islington
Copy link
Contributor

Sorry, @hugovk and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 572678e1f864cb042df6962848a436d84ef7a8a4 3.9

@miss-islington
Copy link
Contributor

Sorry, @hugovk and @ambv, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 572678e1f864cb042df6962848a436d84ef7a8a4 3.8

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 4, 2023
@hugovk @miss-islington
CI: Bump GitHub Actions (pythonGH-108879)
18743c7 
(cherry picked from commit 572678e)

Co-authored-by: Hugo van Kemenade <[email protected]>
@hugovk hugovk deleted the bump-gha branch September 4, 2023 20:58
@bedevere-bot
Copy link

GH-108891 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 4, 2023
@bedevere-bot
Copy link

GH-108892 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 4, 2023
@bedevere-bot
Copy link

GH-108893 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Sep 4, 2023
@bedevere-bot
Copy link

GH-108894 is a backport of this pull request to the 3.8 branch.

hauntsaninja pushed a commit that referenced this pull request Sep 5, 2023
@hugovk
[3.11] CI: Bump GitHub Actions (GH-108879) (#108891)
b26717b 
Bump GitHub Actions
Yhg1s pushed a commit that referenced this pull request Sep 5, 2023
@miss-islington @hugovk
[3.12] CI: Bump GitHub Actions (GH-108879) (#108889)
9c1428c 
CI: Bump GitHub Actions (GH-108879)
(cherry picked from commit 572678e)

Co-authored-by: Hugo van Kemenade <[email protected]>
ambv added a commit that referenced this pull request Sep 5, 2023
@hugovk @ambv
[3.9] CI: Bump GitHub Actions (GH-108879) (#108893)
13905c9 
Co-authored-by: Łukasz Langa <[email protected]>
ambv added a commit that referenced this pull request Sep 5, 2023
@hugovk @ambv
[3.10] CI: Bump GitHub Actions (GH-108879) (#108892)
fc756f6 
Co-authored-by: Łukasz Langa <[email protected]>
ambv added a commit that referenced this pull request Sep 7, 2023
@hugovk @ambv
[3.8] CI: Bump GitHub Actions (GH-108879) (#108894)
edf701c 
Co-authored-by: Łukasz Langa <[email protected]>
carlosroman pushed a commit to DataDog/cpython that referenced this pull request Oct 11, 2023
@hugovk @ambv @carlosroman
[3.9] CI: Bump GitHub Actions (pythonGH-108879) (python#108893)
4fe0d06 
Co-authored-by: Łukasz Langa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees

@ambv ambv

Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hugovk @sobolevn @Zac-HD @miss-islington @bedevere-bot @ambv