Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-102832: IDLE - update stackviewer open #105528

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Conversation

terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Jun 8, 2023

Use 'last_exc' instead of 'last_value' in 3.12/3.

Use 'last_exc' instead of 'last_value' in 3.12/3.
@terryjreedy
Copy link
Member Author

terryjreedy commented Jun 8, 2023

@iritkatriel This should finish the issue. The only occurrences of the other last_xyz vars are in idlelib.run where they are set in the user globals for back-compatibility.

Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@miss-islington
Copy link
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2023
Use 'last_exc' instead of 'last_value' in 3.12/3.
(cherry picked from commit bb3454c)

Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-bot
Copy link

GH-105534 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jun 8, 2023
@terryjreedy terryjreedy deleted the valexc branch June 8, 2023 22:01
terryjreedy added a commit that referenced this pull request Jun 8, 2023
gh-102832: IDLE - update stackviewer open (GH-105528)

Use 'last_exc' instead of 'last_value' in 3.12/3.
(cherry picked from commit bb3454c)

Co-authored-by: Terry Jan Reedy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news stdlib Python modules in the Lib dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants