Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-102856: Update "Formatted string literals" docs section after PEP701 #104861

Merged
merged 1 commit into from
May 24, 2023
Merged

gh-102856: Update "Formatted string literals" docs section after PEP701 #104861

merged 1 commit into from
May 24, 2023

Conversation

lysnikolaou
Copy link
Contributor

@lysnikolaou lysnikolaou commented May 24, 2023 •
edited by github-actions bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request May 24, 2023
Closed
4 tasks
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels May 24, 2023
@pablogsal
Copy link
Member

I think we need to fix also the "grammar" that is included here and substitute that for the PEG grammar

@pablogsal
Copy link
Member

image

I mean this one

@lysnikolaou
Copy link
Contributor Author

I think we need to fix also the "grammar" that is included here and substitute that for the PEG grammar

Not sure about that. The existing grammar feels easier to read. Since the purpose of this is to give an overview of what can go into an f-string, I don't think we should over-complicate stuff with FSTRING_START, FSTRING_END etc.

@pablogsal
Copy link
Member

Hummmm IIRC that grammar is slightly incorrect or it was missing some details. Check it out and if you are happy with it then let's keep it

@lysnikolaou
Copy link
Contributor Author

I briefly compared it with our version in the PEG and it seems okay to me. If you're also okay with it, we can merge.

pablogsal
pablogsal approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Great work!

@lysnikolaou lysnikolaou added the needs backport to 3.12 bug and security fixes label May 24, 2023
@lysnikolaou lysnikolaou merged commit 8e5b3b9 into python:main May 24, 2023
@miss-islington
Copy link
Contributor

Thanks @lysnikolaou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2023
@lysnikolaou @miss-islington
pythongh-102856: Update "Formatted string literals" docs section afte…
e867088 
…r PEP701 (pythonGH-104861)

(cherry picked from commit 8e5b3b9)

Co-authored-by: Lysandros Nikolaou <[email protected]>
@bedevere-bot
Copy link

GH-104865 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label May 24, 2023
lysnikolaou added a commit that referenced this pull request May 24, 2023
@miss-islington @lysnikolaou
[3.12] gh-102856: Update "Formatted string literals" docs section aft…
25890eb 
…er PEP701 (GH-104861) (#104865)

(cherry picked from commit 8e5b3b9)

Co-authored-by: Lysandros Nikolaou <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lysnikolaou @pablogsal @miss-islington @bedevere-bot