gh-101282: Group and quote BOLT CLI flags

[erlend-aasland]

• Issue: Enhance the BOLT build process #101282

[corona10]

I am not sure why you want to separate the BOLT options.
Please don't do this, let's maintain options as easy possible.
#104752 is not enough?

[corona10]

When I talked about grouping the BOLT options, it doesn't mean separating them as variables.
It was about sorting.

[corona10]

One pain point of this change is we have to care double quote in multiple places.
(defining BOLT_GENERIC_OPTIONS, defining BOLT_OPTIMIZATION_OPTIONS and BOLT_GENERIC_OPTIONS + BOLT_OPTIMIZATION_OPTIONS)

[erlend-aasland]

I disagree; I don't see that as a "pain point".

[corona10]

I disagree; I don't see that as a "pain point".

Well, My preference is don't care about double quotes as possible.
(This was the root cause of this issue in my guess)
I feel quite uncomfortable maintaining three elements that should be noted by double quotes.
It could be my personal preference. but yeah that's why I said pain point.

[erlend-aasland]

I am not sure why you want to separate the BOLT options.
Please don't do this, let's maintain options as easy possible.

Currently, we only apply BOLT options to the optimisation stage. What if we want to add options during the instrumentation stage as well? In that case, won't it make sense to apply the generic flags to both stages? If so, will it not be easier to set the generic flags just once? Correct me if I'm wrong.

[corona10]

What if we want to add options during the instrumentation stage as well?


I am not sure at this moment, but my mind is reducing the unnecessary option as possible.
(If my hypothesis is correct, only the binary relocation option will remain)

[erlend-aasland]

Closing this, as grouping is no longer needed.