You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be better to move the responsibility to the child watchers for calling callbacks on the event loop thread. Currently the callback needs to defensively call call_soon_threadsafe which is redundant on the Pidfdchildwatcher
gvanrossum
changed the title
redundant call to call_soon_threasafe when using Pidfdchildwatcher
Redundant call to call_soon_threasafe when using PidfdChildWatcher
Oct 8, 2022
Yeah, I notied this too when @1st1 and I were reviewing the watcher code this morning. Not sure we need to keep an issue open to remind us of this though.
It would be better to move the responsibility to the child watchers for calling callbacks on the event loop thread. Currently the callback needs to defensively call
call_soon_threadsafe
which is redundant on the PidfdchildwatcherEg
cpython/Lib/asyncio/unix_events.py
Lines 225 to 227 in 282edd7
Originally posted by @graingert in #94597 (comment)
The text was updated successfully, but these errors were encountered: