Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[coverage] tokenizer.c: valid_utf8 #94823

Closed
Tracked by #94808
mdboom opened this issue Jul 13, 2022 · 1 comment
Closed
Tracked by #94808

[coverage] tokenizer.c: valid_utf8 #94823

mdboom opened this issue Jul 13, 2022 · 1 comment
Labels
type-bug An unexpected behavior, bug, or error

Comments

@mdboom
Copy link
Contributor

mdboom commented Jul 13, 2022

valid_utf8 seems to never be fed invalid UTF-8 by the test suite.
@mdboom mdboom added the type-bug An unexpected behavior, bug, or error label Jul 13, 2022
@mdboom mdboom mentioned this issue Jul 13, 2022
Open
@bedevere-bot bedevere-bot mentioned this issue Jul 14, 2022
Merged
mdboom added a commit to mdboom/cpython that referenced this issue Jul 15, 2022
@mdboom
pythongh-94823: Improve coverage in tokenizer.c:valid_utf8
e52f328 
When loading a source file from disk, there is a separate UTF-8 validator
distinct from the one in `unicode_decode_utf8`. This exercises that code path
with the same set of invalid inputs as we use for testing the "other" UTF-8
decoder.
miss-islington pushed a commit that referenced this issue Aug 16, 2022
@mdboom
gh-94823: Improve coverage in tokenizer.c:valid_utf8 (GH-94856)
f215d7c 
When loading a source file from disk, there is a separate UTF-8 validator
distinct from the one in `unicode_decode_utf8`. This exercises that code path
with the same set of invalid inputs as we use for testing the "other" UTF-8
decoder.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 16, 2022
@mdboom @miss-islington
pythongh-94823: Improve coverage in tokenizer.c:valid_utf8 (pythonGH-…
0425b23 
…94856)

When loading a source file from disk, there is a separate UTF-8 validator
distinct from the one in `unicode_decode_utf8`. This exercises that code path
with the same set of invalid inputs as we use for testing the "other" UTF-8
decoder.
(cherry picked from commit f215d7c)

Co-authored-by: Michael Droettboom <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Aug 16, 2022
Merged
pablogsal pushed a commit that referenced this issue Aug 16, 2022
@miss-islington @mdboom
[3.11] gh-94823: Improve coverage in tokenizer.c:valid_utf8 (GH-94856) (
2bb363c 
#96029)

Co-authored-by: Michael Droettboom <[email protected]>
@kumaraditya303
Copy link
Contributor

Fixed by #94856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdboom @kumaraditya303