Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[coverage] codeobject.c: _PyCode_CreateLineArray #94814

Closed
Tracked by #94808
mdboom opened this issue Jul 13, 2022 · 1 comment
Closed
Tracked by #94808

[coverage] codeobject.c: _PyCode_CreateLineArray #94814

mdboom opened this issue Jul 13, 2022 · 1 comment
Assignees
@mdboom
Labels
type-bug An unexpected behavior, bug, or error

Comments

@mdboom
Copy link
Contributor

mdboom commented Jul 13, 2022

In _PyCode_CreateLineArray, the code path where there are greater than 2**16 lines doesn't seem to be exercised.
@mdboom mdboom added the type-bug An unexpected behavior, bug, or error label Jul 13, 2022
@mdboom mdboom mentioned this issue Jul 13, 2022
Open
@mdboom
Copy link
Contributor Author

mdboom commented Jul 14, 2022

I can't self-assign, but FYI I'm working on this.

mdboom added a commit to mdboom/cpython that referenced this issue Jul 14, 2022
@mdboom
pythongh-94814: Improve coverage of _PyCode_CreateLineArray
1c6af67 
The case where there are more than (1 << 15) lines was not covered
@bedevere-bot bedevere-bot mentioned this issue Jul 14, 2022
Merged
@bedevere-bot bedevere-bot mentioned this issue Jul 15, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 15, 2022
@mdboom @miss-islington
pythongh-94814: Improve coverage of _PyCode_CreateLineArray (pythonGH…
5708c14 
…-94852)

The case where there are more than (1 << 15) lines was not covered.

I don't know if increasing test coverage requires a blurb -- let me know if it does.

Automerge-Triggered-By: GH:brandtbucher
(cherry picked from commit 582ae86)

Co-authored-by: Michael Droettboom <[email protected]>
miss-islington pushed a commit that referenced this issue Jul 15, 2022
@mdboom
gh-94814: Improve coverage of _PyCode_CreateLineArray (GH-94852)
582ae86 
The case where there are more than (1 << 15) lines was not covered.

I don't know if increasing test coverage requires a blurb -- let me know if it does.

Automerge-Triggered-By: GH:brandtbucher
miss-islington added a commit that referenced this issue Jul 15, 2022
@miss-islington @mdboom
gh-94814: Improve coverage of _PyCode_CreateLineArray (GH-94852)
8f92ebb 
The case where there are more than (1 << 15) lines was not covered.

I don't know if increasing test coverage requires a blurb -- let me know if it does.

Automerge-Triggered-By: GH:brandtbucher
(cherry picked from commit 582ae86)

Co-authored-by: Michael Droettboom <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdboom mdboom

Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdboom @brandtbucher